Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ente-auth: 4.0.2 -> 4.1.0 #357503

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Nov 20, 2024

https://github.com/ente-io/ente/releases/tag/auth-v4.1.0

This update fixes a security issue and should thus be backported to NixOS 24.11.

Note that due to a rename of the data directory and the binary in upstream, this update is not backwards compatible.
Ente-auth will automatically migrate the old data directory on first launch, meaning a rollback from 4.1.0 to 4.0.2 may lead to data loss.

Currently in draft mode as it does not build yet.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@niklaskorz niklaskorz mentioned this pull request Nov 20, 2024
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 21, 2024
@zi3m5f
Copy link
Contributor

zi3m5f commented Nov 21, 2024

This update fixes a security issue and should thus be backported to NixOS 24.11.

I am not sure how urgent ente-io/ente#3545 is but maybe we should try to only backport the fix to 24.11 and decide later if we want to update to 4.1.x?

@zi3m5f
Copy link
Contributor

zi3m5f commented Nov 21, 2024

Currently in draft mode as it does not build yet.

error: hash mismatch in fixed-output derivation '/nix/store/ihbvpyw1ammkfxj1jzwyx1vm0vb5z5jb-pub-sqflite-2.3.3+2.drv':
         specified: sha256-TdvCtEO7KL1R2oOSwGWllmS5kGCIU5CkvvUqUJf3tUc=
            got:    sha256-+XTVtkFJ94VifwnutvUuAqqiyWwrcEiZ3Uz0H4D9zWA=
error: hash mismatch in fixed-output derivation '/nix/store/qx291zbh1gvkgbjv5gkkm0507fhb2987-source.drv':
         specified: sha256-6fJ0OAZ9p8+zanPl39p3VX9xUMGV47klcwfEnwyRX98=
            got:    sha256-ytKGRsBhKD/GfaWiFvhT0g+UzG7mZI100Ws1GBibsxI=

@niklaskorz
Copy link
Contributor Author

niklaskorz commented Nov 21, 2024

Currently in draft mode as it does not build yet.

error: hash mismatch in fixed-output derivation '/nix/store/ihbvpyw1ammkfxj1jzwyx1vm0vb5z5jb-pub-sqflite-2.3.3+2.drv':
         specified: sha256-TdvCtEO7KL1R2oOSwGWllmS5kGCIU5CkvvUqUJf3tUc=
            got:    sha256-+XTVtkFJ94VifwnutvUuAqqiyWwrcEiZ3Uz0H4D9zWA=
error: hash mismatch in fixed-output derivation '/nix/store/qx291zbh1gvkgbjv5gkkm0507fhb2987-source.drv':
         specified: sha256-6fJ0OAZ9p8+zanPl39p3VX9xUMGV47klcwfEnwyRX98=
            got:    sha256-ytKGRsBhKD/GfaWiFvhT0g+UzG7mZI100Ws1GBibsxI=

Yup that's where I am stuck, any idea what might cause the mismatch?

@gepbird
Copy link
Contributor

gepbird commented Nov 21, 2024

Currently in draft mode as it does not build yet.

error: hash mismatch in fixed-output derivation '/nix/store/ihbvpyw1ammkfxj1jzwyx1vm0vb5z5jb-pub-sqflite-2.3.3+2.drv':
         specified: sha256-TdvCtEO7KL1R2oOSwGWllmS5kGCIU5CkvvUqUJf3tUc=
            got:    sha256-+XTVtkFJ94VifwnutvUuAqqiyWwrcEiZ3Uz0H4D9zWA=
error: hash mismatch in fixed-output derivation '/nix/store/qx291zbh1gvkgbjv5gkkm0507fhb2987-source.drv':
         specified: sha256-6fJ0OAZ9p8+zanPl39p3VX9xUMGV47klcwfEnwyRX98=
            got:    sha256-ytKGRsBhKD/GfaWiFvhT0g+UzG7mZI100Ws1GBibsxI=

I got these hashes too, not sure why they changed, last update to the auth-v4.1.0 branch was 2 weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants