This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Allow visualizations to define context module for preprocessor #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwu-tow
added
Difficulty: Core Contributor
wdanilo
approved these changes
Mar 5, 2021
Comment on lines
+27
to
28
| // TODO [mwu] This should return Rc<ReferentName>. | ||
| fn name(&self) -> ImString; |
There was a problem hiding this comment.
Why ReferentName is not immutable by default (Why it doesn't embed Rc inside?)
There was a problem hiding this comment.
It was introduced as a replacement for non-immutable String. Types in double representation module generally expect that Rc will be used on them, rather than built it in.
src/rust/ide/view/graph-editor/src/component/visualization/foreign/java_script/visualization.js
Outdated
Show resolved
Hide resolved
src/rust/ide/view/graph-editor/src/component/visualization/foreign/java_script/visualization.js
Outdated
Show resolved
Hide resolved
farmaazon
reviewed
Mar 5, 2021
src/rust/ide/view/graph-editor/src/builtin/visualization/native/error.rs
Outdated
Show resolved
Hide resolved
src/rust/ide/view/graph-editor/src/component/visualization/foreign/java_script/binding.rs
Outdated
Show resolved
Hide resolved
src/rust/ide/view/graph-editor/src/component/visualization/foreign/java_script/binding.rs
Outdated
Show resolved
Hide resolved
src/rust/ide/view/graph-editor/src/component/visualization/instance.rs
Outdated
Show resolved
Hide resolved
…ps://github.com/enso-org/ide into wip/mwu/visualization-module-configuration-1167
farmaazon
suggested changes
Mar 5, 2021
There was a problem hiding this comment.
- The Table visualization doesn't work. IDE receives an update from the Engine, but nothing is displayed in visualization. Attached to one of the initial nodes in scene of fresh project.
- Dataflow errors are not displayed. Try put
1.div 0node. There should be error message below.
…sualization-module-configuration-1167
farmaazon
approved these changes
Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Ref #1167.
Along the way, I've allowed visualizations to define preprocessor during the construction phase, removing need for workaround where it was changed only after first update.
Setting proper module for geomap allowed to significantly simplify code.
A few refactorings along the way.
Important Notes
Build requires parser fix from https://github.com/enso-org/rust-lib/pull/34
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.- [ ] All code has automatic tests where possible.- [ ] All code has been profiled where possible.