Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying evaluation module of visualization preprocessor. #2705

Closed
farmaazon opened this issue Jan 29, 2021 · 1 comment
Closed

Specifying evaluation module of visualization preprocessor. #2705

farmaazon opened this issue Jan 29, 2021 · 1 comment
Assignees

Comments

@farmaazon
Copy link
Contributor

Summary

The @kustosz 's comment regarding current visualization API:

The current documentation (https://github.com/enso-org/ide/blob/main/src/rust/ide/view/graph-editor/src/component/visualization/foreign/java_script/definition.rs#L55) describes setPreprocessor as taking a code string.
However, I find it important to also handle the second parameter exposed by the backend – the evaluation module:
https://dev.enso.org/docs/enso/language-server/protocol-language-server.html#visualisationconfiguration

This is important to ensure visualizations can be created independent of the data definitions.
If you don't want to always pass this argument, a sensible default would be the module Main of the project defining the visualizations (not the current project! the project that defines the visualisation). However, an option to override should be available.

Value

See above

Specification

So, the setPreprocessor function could take an additional optional argument with the module name, and set it in the Engine. The default module should be as described above + the builtin visualizations should have Base.Main (perhaps).

Acceptance Criteria & Test Cases

Run IDE, show some visualization and see the messages sent to Engine in Network tab.

@MichaelMauderer
Copy link
Contributor

When resolving this, please also revert the workaround in geoMap.js#L14`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants