Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More type-checking for concrete children #9375

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Mar 12, 2024

Pull Request Description

Introduce a concrete NodeChild subtype; use it to statically check for the kind of bug that #9357 fixed.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Mar 12, 2024
@kazcw kazcw self-assigned this Mar 12, 2024
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Mar 12, 2024
@mergify mergify bot merged commit 39976be into develop Mar 12, 2024
33 of 34 checks passed
@mergify mergify bot deleted the wip/kw/concrete-child-type branch March 12, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants