Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐Building up the vector of joins fails when adding second entry (extra white space added). #9357

Closed
Tracked by #9354
farmaazon opened this issue Mar 11, 2024 · 1 comment · Fixed by #9366
Closed
Tracked by #9354

⭐Building up the vector of joins fails when adding second entry (extra white space added). #9357

farmaazon opened this issue Mar 11, 2024 · 1 comment · Fixed by #9366
Assignees
@farmaazon
Labels
--bug Type: bug -gui p-highest Should be completed ASAP

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Mar 11, 2024 •
edited
Loading

From #9354 (comment)

on= [ (Join_Condition.Equals 'Year'), (Join_Condition.Equals 'Year')]

2024-03-11_10-40-13.mp4
@farmaazon farmaazon mentioned this issue Mar 11, 2024
Closed
@farmaazon farmaazon added --bug Type: bug -gui p-highest Should be completed ASAP labels Mar 11, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Mar 11, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 👁️ Code review in Issues Board Mar 11, 2024
@farmaazon farmaazon moved this from 👁️ Code review to 🔧 Implementation in Issues Board Mar 11, 2024
@farmaazon farmaazon self-assigned this Mar 11, 2024
@farmaazon farmaazon mentioned this issue Mar 11, 2024
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 11, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-03-11):

Progress: Debugged, and - with Paweł and Kaz help - fixed the issue. It should be finished by 2024-03-11.

Next Day: Next day I will be working on the #9058 task. Go back to widget filtering, and hopefull finish it.

@mergify mergify bot closed this as completed in #9366 Mar 12, 2024
mergify bot pushed a commit that referenced this issue Mar 12, 2024
@farmaazon
Fix AST spacing (#9366)
a01aeab 
Fixes #9357

The main issue was the spread operator using at the wrong place in functions overriding spacing of nodes. The bug, to be visible, required copying AST node before, because during copying `whitespace` field was explicitly set to undefined (in opposite to being unset), what in turns make spread overriding the value set by those functions.

# Important Notes
* To enable VSCode debugging, added a workspace for vitest and fix any relative path to be working-dir independent.
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Mar 12, 2024
@kazcw kazcw mentioned this issue Mar 12, 2024
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Mar 12, 2024
@kazcw
More type-checking for concrete children (#9375)
39976be 
Introduce a concrete NodeChild subtype; use it to statically check for the kind of bug that #9357 fixed.
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
--bug Type: bug -gui p-highest Should be completed ASAP
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AST spacing enso-org/enso
1 participant
@farmaazon