Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal type: constuctors, comparisons, and arithmetic #9272

Merged
merged 167 commits into from
Mar 15, 2024
Merged

Decimal type: constuctors, comparisons, and arithmetic #9272

merged 167 commits into from
Mar 15, 2024

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Mar 4, 2024 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

GregoryTravis and others added 30 commits February 9, 2024 14:16
@GregoryTravis
new
c114553
@GregoryTravis
+
413aed8
@GregoryTravis
MathContext, RoundingMode
a4809bf
@GregoryTravis
froms
560120f
@GregoryTravis
Merge branch 'develop' into wip/gmt/8982-decimal
cd0b29c
@GregoryTravis
mc has precision, not scale
dd770b1
@GregoryTravis
from_text, nfe
68043fd
@GregoryTravis
text ctor with mc
e5b2867
@GregoryTravis
from_text directly
d69cae2
@GregoryTravis
from_integer, with small tests
0612bb8
@GregoryTravis
redundant test
09f2c21
@GregoryTravis
wip
29d0089
@GregoryTravis
large
79826a2
@GregoryTravis
inline return types
413cf42
@GregoryTravis
ctor docs
7a940f4
@GregoryTravis
long string
fa10645
@GregoryTravis
Merge branch 'develop' into wip/gmt/8982-decimal
1b2b31d
@GregoryTravis
float ctor
9d422b8
@GregoryTravis
Merge branch 'develop' into wip/gmt/8982-decimal
503f314
@GregoryTravis
no precision loss in default double conversion
50f7a94
@GregoryTravis
wip
134e1dc
@JaroslavTulach
Enabling equality tests for Complex and Number
dce1b25
@JaroslavTulach
Adding one more node in front of previously existing EqualsNode
7c46739
@JaroslavTulach
First of all compute results only then verify them
b0a4e48
@JaroslavTulach
Number can be equal to different type. Check with ==
9f4cde3
@JaroslavTulach
Supporting conversions during evaluation of ==
a214c0b
@JaroslavTulach
Removing accidentally committed fix from other PR
a2bfb88
@JaroslavTulach
TruffleObject vs. boolean specialization
10f7941
@JaroslavTulach
Encapsulating in equalityCheck method
b308014
@JaroslavTulach
Uncached version of the node may not use cached libraries
290b63b
radeusgd
radeusgd reviewed Mar 12, 2024
View reviewed changes
test/Base_Tests/src/Data/Decimal_Spec.enso
Comment on lines +467 to +473
group_builder.specify "should negate values correctly" <|
Decimal.new 5 . negate . should_equal -5
Decimal.new -5 . negate . should_equal 5
Decimal.new 5.3 . negate . should_equal -5.3
Decimal.new -5.3 . negate . should_equal 5.3
Decimal.new 0 . negate . should_equal 0
Decimal.new -0 . negate . should_equal 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would we need to add to be able to support

d = Decimal.new 4
x = -d
x.should_equal -4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already supported; added tests for this format.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@GregoryTravis GregoryTravis requested a review from radeusgd March 12, 2024 19:42
radeusgd
radeusgd approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Mar 12, 2024
@GregoryTravis GregoryTravis mentioned this pull request Mar 12, 2024
Closed
@enso-bot enso-bot bot mentioned this pull request Mar 13, 2024
Closed
@GregoryTravis GregoryTravis removed the CI: Ready to merge This PR is eligible for automatic merge label Mar 13, 2024
@GregoryTravis GregoryTravis added CI: Ready to merge This PR is eligible for automatic merge CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Mar 15, 2024
@GregoryTravis GregoryTravis mentioned this pull request Mar 15, 2024
Closed
6 tasks
@mergify mergify bot merged commit 9a9eff1 into develop Mar 15, 2024
40 checks passed
@mergify mergify bot deleted the wip/gmt/8982-decimal branch March 15, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd radeusgd approved these changes

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregoryTravis @radeusgd @jdunkerley @JaroslavTulach