Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate completion of Table.join join criteria using data from both joined tables #5629

Closed
Frizi opened this issue Feb 10, 2023 · 23 comments · Fixed by #9410
Closed

Generate completion of Table.join join criteria using data from both joined tables #5629

Frizi opened this issue Feb 10, 2023 · 23 comments · Fixed by #9410
Assignees
@JaroslavTulach
Labels
-gui -language-server -libs Libraries: New libraries to be implemented p-medium Should be completed in the next few sprints x-new-feature Type: new feature request

Comments

@Frizi
Copy link
Contributor

Frizi commented Feb 10, 2023

Currently the completion forTable.join on parameter only takes the left-side table columns into account.
image
Ideally we want to compute the widget entries using column names from both tables. That requires new IDE and engine capabilities:

  • Method metadata querying API needs to allow for providing more than one argument value.
  • Visualization API needs to be extended to allow specifying multiple expressions for evaluation at once. Currently it is limited to one per visualization.
  • Selection of requested method arguments to send for widget query needs to be specified, possibly as part of suggestion database, or as a widget metadata itself (that would require prior splitting of widget metadata and values query).

Acceptance criteria:

Table.join method on widget completion allows selecting join criteria using column names from both tables.
@Frizi Frizi added x-new-feature Type: new feature request p-low Low priority -gui -language-server labels Feb 10, 2023
@jdunkerley jdunkerley moved this from ❓New to ⚙️ Design in Issues Board Feb 14, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Feb 14, 2023
@jdunkerley jdunkerley added the -libs Libraries: New libraries to be implemented label Feb 21, 2023
@jdunkerley jdunkerley mentioned this issue Feb 21, 2023
Closed
@jdunkerley jdunkerley moved this from ⚙️ Design to 📤 Backlog in Issues Board Aug 15, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Aug 29, 2023
@jdunkerley jdunkerley added p-medium Should be completed in the next few sprints and removed p-low Low priority labels Sep 1, 2023
@jdunkerley jdunkerley removed this from the Beta Release milestone Sep 1, 2023
@jdunkerley
Copy link
Member

As part of the JS Vue IDE work the ability to do this must be considered.

@Frizi
Copy link
Contributor Author

Frizi commented Sep 1, 2023 •
edited
Loading

So far, the limitation for this issue has been on the protocol level, not on UI. The discussion on it was started, but without any response yet https://github.com/orgs/enso-org/discussions/6832

GitHub
Currently, the data for dynamic node widgets is requested using language server's Visualization API. That allows us to resolve method annotations using the data from evaluated method call's target....

@JaroslavTulach
Copy link
Member

Trying to recollect my previous thoughts and work on this topic reminds me of

Take a look at * instead of + test to see that there already is a way for an Enso code (including visualization code - I hope) to observe not only self, but also other arguments when a call is made. E.g. once one:

All that is needed (from my point of view) is to design an experiment to use this mechanism in the IDE. What one needs to do on the IDE side to invoke the instrumenter, @Frizi? How are the visualizations done in the GUI2?

@farmaazon farmaazon added -gui and removed -gui labels Feb 27, 2024
@enso-bot enso-bot bot mentioned this issue Feb 28, 2024
Closed
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Mar 5, 2024
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to ⚙️ Design in Issues Board Mar 6, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 12, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-11):

Progress: - prototypingTable.join

Next Day: PoC for Table.join

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
GitHub
Pull Request Description Fixes #9275. Checklist Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
All code...

@enso-bot
Copy link

enso-bot bot commented Mar 13, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-12):

Progress: - Table.join prototyping - IDE sends more data

Next Day: Extract UUIDs for arguments in visualization

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@enso-bot
Copy link

enso-bot bot commented Mar 14, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-13):

Progress: - discussing WASM in y.js: https://discord.com/channels/@me/968956156758343744/1217509898414325900

Next Day: Use UUIDs from arguments in visualization

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@JaroslavTulach JaroslavTulach mentioned this issue Mar 14, 2024
Merged
3 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 15, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-14):

Progress: - Poc of Table.join: #9410

Next Day: Debugging & bugfixing

@enso-bot
Copy link

enso-bot bot commented Mar 16, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-15):

Progress: - better foreign js debugging and coloring: #9440

Next Day: Instrumentation of autoscoped constructors

@enso-bot
Copy link

enso-bot bot commented Mar 19, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-18):

Progress: - debuggging autoscoped constructors

Next Day: Finish onstrumentation of autoscoped constructors

@enso-bot
Copy link

enso-bot bot commented Apr 11, 2024

Jaroslav Tulach reports a new 🔴 DELAY for yesterday (2024-04-10):

Summary: There is 30 days delay in implementation of the Generate completion of Table.join join criteria using data from both joined tables (#5629) task.
It will cause 30 days delay for the delivery of this weekly plan.

Table.join is complicated

Delay Cause: After prototyping, I was working on something else

Possible solutions: Focus, focus, focus!

@enso-bot
Copy link

enso-bot bot commented Apr 11, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-10):

Progress: - reviews

  • meetings and dicussions It should be finished by 2024-04-17.

@enso-bot
Copy link

enso-bot bot commented Apr 12, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-11):

Progress: - fighting with typescript: #9410 (comment)

@enso-bot
Copy link

enso-bot bot commented Apr 13, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-12):

Progress: - working on Table.join: 81aa216

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for the last Saturday (2024-04-13):

Progress: - describing status of Table.join: https://github.com/orgs/enso-org/discussions/9695#discussioncomment-9101924

GitHub
Radosław: Refactoring Enso_File to be path based #9581 Radosław: Improve handling of File.parent and File.name #9642 Radosław: Make HTTP tests more robust by adding retries to the tests #9652 Rados...

@JaroslavTulach JaroslavTulach mentioned this issue Apr 15, 2024
Closed
@enso-bot
Copy link

enso-bot bot commented Apr 16, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-15):

Progress: - reviewing Table.join PoC with Dmitry

@JaroslavTulach JaroslavTulach moved this from ⚙️ Design to 👁️ Code review in Issues Board Apr 16, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 17, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-16):

Progress: - get_widget_json method with uuids arg: #9410 (comment)

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
Vue.js - The Progressive JavaScript Framework

@enso-bot
Copy link

enso-bot bot commented Apr 18, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-17):

Progress: - thinking about caching: https://github.com/enso-org/enso/blob/fda41cbfd1d1966d8772d1a889905b78651e734e/docs/runtime/caching.md

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@enso-bot
Copy link

enso-bot bot commented Apr 19, 2024

Jaroslav Tulach reports a new 🔴 DELAY for yesterday (2024-04-18):

Summary: There is 6 days delay in implementation of the Generate completion of Table.join join criteria using data from both joined tables (#5629) task.
It will cause 6 days delay for the delivery of this weekly plan.

Delay Cause: functionality is working and is being reviewed, but it needs to be polished and tests written

Possible solutions: Let's plan to integrate by next Tuesday

@enso-bot
Copy link

enso-bot bot commented Apr 19, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-18):

Progress: - 2 == 2.0 - #9607 (comment)

@enso-bot
Copy link

enso-bot bot commented Apr 20, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-19):

Progress: - fixing 2^63: #9740 (comment)

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@enso-bot
Copy link

enso-bot bot commented Apr 22, 2024

Jaroslav Tulach reports a new STANDUP for the last Saturday (2024-04-20):

Progress: - evaluating benchmarks: #9746 (comment)

@enso-bot
Copy link

enso-bot bot commented Apr 23, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-22):

Progress: - Table.join needs final review: #9410

@enso-bot
Copy link

enso-bot bot commented Apr 24, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-04-23):

Progress: - Got review for Table.join: #9410

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
-gui -language-server -libs Libraries: New libraries to be implemented p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Access non-self arguments when widget annotations are computed enso-org/enso
4 participants
@Frizi @farmaazon @jdunkerley @JaroslavTulach