Comment UI refinement #9271
Merged
Comment UI refinement #9271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eliminate edit mode: - Beginning edit does not change appearance - Edit text as rendered, not as formatted in code - Enter finishes edit - Shift+Enter inserts a newline - Click begins edit regardless of Ctrl
kazcw
requested review from
Frizi,
farmaazon,
MichaelMauderer and
vitvakatu
as code owners
vitvakatu
reviewed
Mar 4, 2024
Comment on lines
91
to
97
| export function rawTextToCooked(raw: string) { | ||
| return raw.replaceAll(/(?<!\n)\n(?!\n)/g, ' ').replaceAll(/\n(\n+)/g, '$1') | ||
| } | ||
|
|
||
| export function cookedTextToRaw(cooked: string) { | ||
| return cooked.replaceAll('\n', '\n\n') | ||
| } |
There was a problem hiding this comment.
Could you please add little docs to explain what is the difference?
kazcw
added
the
CI: No changelog needed
Frizi
approved these changes
Mar 12, 2024
Comment on lines
+79
to
+80
| if (props.editing) editor.value.focus() | ||
| else editor.value.contentDOM.blur() |
There was a problem hiding this comment.
This looks little strange as a watchEffect. Could this focus/blur be moved to the interaction methods? Or is there any reason for it being here in particular?
There was a problem hiding this comment.
@Frizi
Watching the prop ensures that focus/blur is updated when we begin/end editing for any reason, e.g:
- If the edit-comment menu icon is clicked, that sets the prop, so the comment is focused when editing begins
- There are various ways editing can be ended, some of them will set a new focus inherently but some don't; if there were any case where we missed unfocusing the comment, a weird state would result in which the app thinks the comment is not being edited but the user still sees a cursor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.