Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a Component with the enter key, editor should scroll to where it is added. #8618

Closed
AdRiley opened this issue Dec 21, 2023 · 2 comments · Fixed by #9273
Closed
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Dec 21, 2023

When adding a Component with the enter key, editor should scroll to where it is added.

@AdRiley AdRiley added the -gui label Dec 21, 2023
@farmaazon farmaazon removed the status in Issues Board Dec 21, 2023
@farmaazon farmaazon moved this to 📤 Backlog in Issues Board Dec 21, 2023
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels Dec 21, 2023
@farmaazon
Copy link
Contributor

Refinement notes:

  • We should do the minimal scroll required to show entire component browser (with some margins)
  • We disregard any corner cases with window too small to fit entire CB.

@farmaazon farmaazon moved this from 📤 Backlog to ⚙️ Design in Issues Board Dec 21, 2023
@farmaazon farmaazon moved this from ⚙️ Design to 📤 Backlog in Issues Board Dec 21, 2023
@AdRiley AdRiley added this to the Beta Release milestone Feb 27, 2024
@kazcw kazcw self-assigned this Mar 4, 2024
@kazcw kazcw moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 4, 2024
@kazcw kazcw linked a pull request Mar 4, 2024 that will close this issue
5 tasks
@kazcw kazcw moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 4, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 5, 2024

Keziah Wesley reports a new STANDUP for today (2024-03-04):

Progress: Implemented comment UI refinements (#9271). Implemented panning to CB. Started on scrollbars. It should be finished by 2024-03-04.

Next Day: Next day I will be working on the #8617 task. Work on adding scrollbars.

@kazcw kazcw moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 6, 2024
@mergify mergify bot closed this as completed in #9273 Mar 6, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants