Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local project manager work against any folder #8985

Merged

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Feb 6, 2024

Pull Request Description

close #8650

Changes in project manager required to work with projects located in custom directories.

Changelog:

  • add: --projects-directory /path/to/projects --project-list command line parameters returning the projects located in custom directory
  • update: project/create, project/open, project/delete, project/rename commands to work with projects located in custom directories

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 6, 2024
@4e6 4e6 self-assigned this Feb 6, 2024
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously I raised a concern about security. I don't see it being addressed. My hacking scenario would be:

  • create private directory and use chmod og-rwx private, put a file there
  • launch project manager
  • connect to the project manager port as another user on the same machine
  • request listing of the private directory

If the listing is denied, then I approve. If the content of the private directory is listed, please seek another approval.

Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Feb 12, 2024
@mergify mergify bot merged commit eb1f529 into develop Feb 12, 2024
29 checks passed
@mergify mergify bot deleted the wip/db/8650-local-project-manager-work-against-any-folder branch February 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Project Manager should be able to work against any folder
3 participants