-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local project manager work against any folder #8985
Local project manager work against any folder #8985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously I raised a concern about security. I don't see it being addressed. My hacking scenario would be:
- create
private
directory and usechmod og-rwx private
, put a file there - launch project manager
- connect to the project manager port as another user on the same machine
- request listing of the
private
directory
If the listing is denied, then I approve. If the content of the private
directory is listed, please seek another approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Description
close #8650
Changes in project manager required to work with projects located in custom directories.
Changelog:
--projects-directory /path/to/projects
--project-list
command line parameters returning the projects located in custom directoryproject/create
,project/open
,project/delete
,project/rename
commands to work with projects located in custom directoriesImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.