-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Project Manager should be able to work against any folder #8650
Comments
I think ideally we would want a way to watch specific folders for status changes (project added, project removed, project state change). Cloud doesn't have this functionality either so it's low priority + probably needs time spent designing it, but I think it's still something we should potentially take into consideration when designing this API. Apart from that, note that the dashboard shows projects in a tree, meaning it can have multiple folders open at once. It's not a big deal since it just uses the underlying Also note that there are a number of operations on projects (cut, copy, duplicate, plus dragging assets to move them around) that should eventually be supported. (Again though, likely out of scope for this initial issue.) |
I imagine it this way. If the user wants to open a project from a different location, Electron should allow opening a native system dialog to choose a directory. After a new directory is selected, you can pass it to the For this to work, we need to update the project manager API to support a new optional interface ProjectListRequest {
numberOfProjects?: Int;
baseDirectory?: string;
} |
@4e6 I think though, that the main usecase would be to be able to browse (and/or watch) an entire directory tree (which should initially be ~/enso?). But it's worth noting that we probably don't want to watch the entire tree right away, because the directory structure might be really deep and/or really big |
@JaroslavTulach pointed out that having a running process that can tell you the contents of a directory is a security vulnerability because the project manager doesn't have authentication and any user of the system can list directories of the user that started the project manager. To mitigate this, instead of using |
Dmitry Bushev reports a new STANDUP for yesterday (2024-02-01): Progress: Started working on the task. Tried to reproduce the issue. Catching up and going through notifications after the vacation. It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2024-02-02): Progress: Continue working on the task. Starting the project list command implementation. Added the CLI parameter and the parameter handling logic. Started working on the JSON conversion of the result. It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
@4e6 just a heads up, cloud does allow opening subdirectories of the root directory. is there a security issue in allowing those without restrictions? |
It is not an issue in the Cloud because we can guarantee that only one user has access to the machine. |
Dmitry Bushev reports a new STANDUP for yesterday (2024-02-05): Progress: Continue working on the task. Implemented the JSON conversion of the command line result. Finished implementation of the command line logic. Tested locally It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2024-02-06): Progress: Continue working on the task. Updated the JSON-RPC protocol of the project manager to allow to work with the projects located in custom directories. Updated the tests. Created the PR. It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
wait, i mean letting the local backend (not the cloud backend) list descendant folders of the initial root directory |
Dmitry Bushev reports a new STANDUP for yesterday (2024-02-07): Progress: Continue working on the task. Debugging the issues with the execution after the restart. Fixed NPE in the expression update serialization. Created a PR It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for today (2024-02-08): Progress: Continue working on the task. Debugging the issues with the execution after the restart. Added cleanup of execution contexts after the client connection is terminated. Created a PR It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
Dmitry Bushev reports a new STANDUP for yesterday (2024-02-09): Progress: Continue working on the task. Was working on the issue with the suggestion updates not properly applied after the restart. Implemented the synchronization of suggestion udpates between the language srever actor logic and the runtime. Started testing. It should be finished by 2024-02-09. Next Day: Next day I will be working on the #8650 task. Continue working on the task |
close #8650 Changes in project manager required to work with projects located in custom directories. Changelog: - add: `--projects-directory /path/to/projects` `--project-list` command line parameters returning the projects located in custom directory - update: `project/create`, `project/open`, `project/delete`, `project/rename` commands to work with projects located in custom directories
The goal is for the local and cloud project managers to have mostly the same functionality.
One step is for the local Project Manager to be based off another folder.
Will need an API for the IDE to be able to change folders.
Goal is for the local IDE to have folder structure visible so you can organize stuff.
The text was updated successfully, but these errors were encountered: