Don't cancel pending visualization's upserts #8853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uniqueness check of `UpsertVisualizationJob` only involved expressionId. Apparently now GUI sends mutliple visualizations for the same expressions and expects all of them to exist. Since previously we would cancel duplicate jobs, this was problematic. This change makes sure that uniqueness also takes into account visualization id. Fixed a few logs that were not passing arguments properly.
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
hubertp
added
the
CI: No changelog needed
Added a problematic case where visualization upserts would get cancelled because uniqueness took into account only expression id but not visualization id. The test is a bit tricky to setup because it relies on a) multiple attach visualization requests b) background job trigger cleaning up duplicate jobs (here triggered via edit)
hubertp
commented
Jan 26, 2024
...ument-common/src/main/scala/org/enso/interpreter/instrument/job/UpsertVisualizationJob.scala
Show resolved
Hide resolved
hubertp
commented
Jan 26, 2024
|
|
||
| attachVisualizationResponses.filter( | ||
| _.payload.isInstanceOf[Api.VisualizationAttached] | ||
| ) shouldEqual List( |
There was a problem hiding this comment.
This test would previously fail.
JaroslavTulach
approved these changes
Jan 26, 2024
...ument-common/src/main/scala/org/enso/interpreter/instrument/job/UpsertVisualizationJob.scala
Show resolved
Hide resolved
hubertp
added
the
CI: Clean build required
|
Based on the last failures I basically think that |
`runtime-instrument-common` depends on `runtime` but `runtime/test` depends indirectly on `runtime-instrument-commont`. We somehow managed to deal with it for modules, but separate compilation breaks everything in CI. This workaround will make sure that CI passes :fingers-crossed:.
The circular dependency between `runtime` and `runtime-instrument-common` is the root of all evil. There is no way around until now, at the cost of some duplication. Should fix issues in incremental compilation when changing between branches.
Working on a fix in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Uniqueness check of
UpsertVisualizationJobonly involved expressionId. Apparently now GUI sends mutliple visualizations for the same expressions and expects all of them to exist. Since previously we would cancel duplicate jobs, this was problematic.This change makes sure that uniqueness also takes into account visualization id. Fixed a few logs that were not passing arguments properly.
Closes #8801
Important Notes
I have not noticed any more problems with loading visualizations so the issue appears to be resolved with this change.
Added a unit test case that would previously fail due to cancellation of a job that upserts visualization.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.