Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After loading project, some visualization does not load. #8801

Closed
Tracked by #8745
farmaazon opened this issue Jan 18, 2024 · 5 comments · Fixed by #8853
Closed
Tracked by #8745

After loading project, some visualization does not load. #8801

farmaazon opened this issue Jan 18, 2024 · 5 comments · Fixed by #8853
Assignees
@hubertp
Labels
--bug Type: bug -language-server d-unknown Difficulty: unable to estimate difficulty p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Jan 18, 2024 •
edited
Loading

When opening the following project, the lowest visualizations seem to be stuck at loading state:

Bookclub_17_01.zip

We receive some "Visualization not found" log

Image
@farmaazon farmaazon mentioned this issue Jan 18, 2024
Closed
@farmaazon farmaazon added p-medium Should be completed in the next few sprints --bug Type: bug triage -gui labels Jan 18, 2024
@farmaazon farmaazon self-assigned this Jan 19, 2024
@farmaazon farmaazon added d-unknown Difficulty: unable to estimate difficulty triage and removed triage labels Jan 19, 2024
@farmaazon
Copy link
Contributor Author

farmaazon commented Jan 19, 2024 •
edited
Loading

The problem seems to be in the Engine, unfortunately: the network log shows that we attach the visualization, and get "success" response. But the very next modification with same visualization ID returns "Visualization not found" error.

IDE behavior could also be improved: we could re-attach visualization after some failures, and show the error if it won't help instead of infinite replies. I'm going to create a separate issue for it.

cc @hubertp @4e6

@farmaazon farmaazon removed their assignment Jan 19, 2024
@farmaazon farmaazon mentioned this issue Jan 19, 2024
Open
@farmaazon farmaazon removed the -gui label Jan 23, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Jan 23, 2024
@hubertp hubertp moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 24, 2024
@enso-bot enso-bot bot mentioned this issue Jan 24, 2024
Closed
This was referenced Jan 24, 2024
Closed
Merged
@enso-bot
Copy link

enso-bot bot commented Jan 25, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-01-24):

Progress: Investigating visualization failures. Reported more info for flickering visualizations (maybe the two are related). Discussing review for binary operator #8779. It should be finished by 2024-01-25.

Next Day: Next day I will be working on the #8801 task. More testing for the fix, prepare PR and add a test.

@hubertp hubertp mentioned this issue Jan 25, 2024
Closed
@enso-bot
Copy link

enso-bot bot commented Jan 26, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-01-25):

Progress: PR created, working on test cases. Investigating CI timeouts for #8806. It should be finished by 2024-01-25.

Next Day: Next day I will be working on the #8806 task. Finish adding a test case. Investigate CI failures.

@enso-bot
Copy link

enso-bot bot commented Jan 29, 2024

Hubert Plociniczak reports a new 🔴 DELAY for the provided date (2024-01-26):

Summary: There is 1 day delay in implementation of the After loading project, some visualization does not load. (#8801) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Fighting with our test infrastructure

@enso-bot
Copy link

enso-bot bot commented Jan 29, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-01-26):

Progress: Added a test case. Investigated problems in the cloud related to initialization. Trying to minimize resource usage for #8006. It should be finished by 2024-01-26.

Next Day: Next day I will be working on the #8806 task. Continue investigating #8806

@hubertp hubertp moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 29, 2024
@mergify mergify bot closed this as completed in #8853 Jan 30, 2024
mergify bot pushed a commit that referenced this issue Jan 30, 2024
@hubertp
Don't cancel pending visualization's upserts (#8853)
081c8c8 
Uniqueness check of `UpsertVisualizationJob` only involved expressionId. Apparently now GUI sends mutliple visualizations for the same expressions and expects all of them to exist. Since previously we would cancel duplicate jobs, this was problematic.

This change makes sure that uniqueness also takes into account visualization id. Fixed a few logs that were not passing arguments properly.

Closes #8801

# Important Notes
I have not noticed any more problems with loading visualizations so the issue appears to be resolved with this change.
Added a unit test case that would previously fail due to cancellation of a job that upserts visualization.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jan 30, 2024
This was referenced Jan 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertp hubertp

Labels
--bug Type: bug -language-server d-unknown Difficulty: unable to estimate difficulty p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't cancel pending visualization's upserts enso-org/enso
2 participants
@hubertp @farmaazon