Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark to measure startup time #8378

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Nov 23, 2023

Pull Request Description

While trying to speed MetadataStorage up - #8324 - I felt the need to have an independent (on my computer) measurement of startup time. Here is a benchmark that measures how long execution of two simple hello world programs take.

Important Notes

There are two benchmarks:

  • empty_startup measures the time needed to boot without using any Standard library - basically an overhead of the JVM and engine
  • hello_world_startup measures the use of IO.println - it shall take longer than empty_startup and show the overhead we have while processing the standard library

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    style guides.
  • All code has been tested:

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 23, 2023
@JaroslavTulach JaroslavTulach self-assigned this Nov 23, 2023
@JaroslavTulach JaroslavTulach changed the title Need an independent measurement of a startup time Benchmark to measure startup time Nov 23, 2023
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting benchmark. It would be nice to have it under engine benchmarks in Java, but fetching the enso executable in Java is cumbersome. This is better solution for now.

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Nov 23, 2023
@mergify mergify bot merged commit 4464a15 into develop Nov 23, 2023
31 of 32 checks passed
@mergify mergify bot deleted the wip/jtulach/BenchmarkStartup_8324 branch November 23, 2023 21:31
@JaroslavTulach JaroslavTulach restored the wip/jtulach/BenchmarkStartup_8324 branch November 24, 2023 06:03
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
Adjustments to #8378 to make sure it runs with `std-benchmarks/benchOnly Startup`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants