3% speedup with LazyMap and MetadataStorage

[JaroslavTulach]

Pull Request Description

Shall optimize #8324 by making all deserialized Map implementations (both Java and Scala) lazy.

Important Notes

I don't know how to convert Java Map to Scala immutable Map without copying - e.g. lazily. Scala experts please advice!

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• All code follows the
  Scala,
  Java,
  style guides.
• All code has been tested:
  • Unit tests have been written where possible.

[JaroslavTulach]

Lazy deserialization of BindingsMap may fail: https://github.com/enso-org/enso/actions/runs/6974085571/job/18979188994?pr=8359#step:10:1073 - don't propagate the IOException further.

[JaroslavTulach]

Reparse without caching when lazy deserialization fails.

[JaroslavTulach]

OK, we are green. Now we need to judge whether this change worths being integrated, @hubertp?

Cons

The BindingsMap may turn to be broken during its deserialization (because calling its restoreFromSerialization which may yield an IOException later when traversing the IR). Now, when we are doing lazy deserialization the IOException signaling that BindingsMap cannot be created can be emitted at random places. When asking for getMetadata(BindingAnalysis), or when calling Module.getBindingsMap it may fail.

Pros

We can gain some speed. The base benchmark results are finally available. Let's schedule benchmark run with this PR - on develop: 3983, 3985, 3968 ms - with this PR: 3855, 3858, 3872 ms. E.g. the speedup is 100ms - e.g. 3%.

Decision

Today's a decision was made to integrate in spite of the "Cons".