Actually fix Lint CI

[somebody1234]

Pull Request Description

My suspicions were correct... it seems like the failures mainly (if not only) happen on a clean repository without build artifacts.
I've fixed it so it will work anyway - it's not pretty but I think it's all required

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[somebody1234]

@wdanilo you pointed out it was verbose before... well, it's so much more verbose now DX

the alternative solution would be to remove all this specialcasing, and then just check for the existence of e.g. build.json and run a build if it's not there. thoughts?

enso/app/ide-desktop/lib/types/modules.d.ts

Lines 17 to 45 in 71ccc1d

	declare module '*/ensogl-pack/linked-dist' {
	/* eslint-disable @typescript-eslint/consistent-type-imports, no-restricted-syntax, @typescript-eslint/no-shadow */
	export type App = import('runner/index').App
	export const App: typeof import('runner/index').App
	export type Consumer = import('runner/index').Consumer
	export const Consumer: typeof import('runner/index').Consumer
	export type LogLevel = import('runner/index').LogLevel
	export const LogLevel: typeof import('runner/index').LogLevel
	export type Logger = import('runner/index').Logger
	export const Logger: typeof import('runner/index').Logger
	export type Option<T> = import('runner/index').Option<T>
	export const Option: typeof import('runner/index').Option
	export const log: typeof import('runner/index').log
	export const logger: typeof import('runner/index').logger
	export const urlParams: typeof import('runner/index').urlParams
	export namespace config {
	export type Option<T> = import('runner/index').config.Option<T>
	export const Option: typeof import('runner/index').config.Option
	export type Group<
	Options extends OptionsRecord,
	Groups extends GroupsRecord
	> = typeof import('runner/index').config.Group<Options, Groups>
	export const Group: typeof import('runner/index').config.Group
	export const objectToGroup: typeof import('runner/index').config.objectToGroup
	export const objectToOption: typeof import('runner/index').config.objectToOption
	export const options: typeof import('runner/index').config.options
	}
	/* eslint-enable @typescript-eslint/consistent-type-imports, no-restricted-syntax, @typescript-eslint/no-shadow */
	}

[wdanilo]

@wdanilo you pointed out it was verbose before... well, it's so much more verbose now DX

the alternative solution would be to remove all this specialcasing, and then just check for the existence of e.g. build.json and run a build if it's not there. thoughts?

enso/app/ide-desktop/lib/types/modules.d.ts

Lines 17 to 45 in 71ccc1d

	declare module '*/ensogl-pack/linked-dist' {
	/* eslint-disable @typescript-eslint/consistent-type-imports, no-restricted-syntax, @typescript-eslint/no-shadow */
	export type App = import('runner/index').App
	export const App: typeof import('runner/index').App
	export type Consumer = import('runner/index').Consumer
	export const Consumer: typeof import('runner/index').Consumer
	export type LogLevel = import('runner/index').LogLevel
	export const LogLevel: typeof import('runner/index').LogLevel
	export type Logger = import('runner/index').Logger
	export const Logger: typeof import('runner/index').Logger
	export type Option<T> = import('runner/index').Option<T>
	export const Option: typeof import('runner/index').Option
	export const log: typeof import('runner/index').log
	export const logger: typeof import('runner/index').logger
	export const urlParams: typeof import('runner/index').urlParams
	export namespace config {
	export type Option<T> = import('runner/index').config.Option<T>
	export const Option: typeof import('runner/index').config.Option
	export type Group<
	Options extends OptionsRecord,
	Groups extends GroupsRecord
	> = typeof import('runner/index').config.Group<Options, Groups>
	export const Group: typeof import('runner/index').config.Group
	export const objectToGroup: typeof import('runner/index').config.objectToGroup
	export const objectToOption: typeof import('runner/index').config.objectToOption
	export const options: typeof import('runner/index').config.options
	}
	/* eslint-enable @typescript-eslint/consistent-type-imports, no-restricted-syntax, @typescript-eslint/no-shadow */
	}

Oh yes, let's do it as you propose please! Let's check for it, build it if it's not there and it'd be much better than this verbosity. Btw, why running build is needed like that? Our build script should build all dependencies automatically, so there should not be a situation when it's not there, right?

[somebody1234]

@wdanilo i think it's because lint doesnt depend on build. i'm not very familiar with the build CLI so maybe it'd be better for @mwu-tow to do it?

[somebody1234]

i think build_ide generates build.json and linked-dist (which are the exact things we need?)
however it seems like most of the defaults are coming from clap, so it's difficult to just build ide programmatically

[wdanilo]

this is terribly verbose and hard to maintain. I understand that the second PR is an alternative to this one, without this verbosity. Am I correct?

[somebody1234]

yeah - i definitely agree the other one is cleaner... and more importantly, doesnt require manually adding or removing exports

[somebody1234]

superseded by #6603