Fix lint CI on cleaned repo

app/ide-desktop/lib/client/tsconfig.json

@@ -2,7 +2,10 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "./src",
-    "esModuleInterop": true
+    "esModuleInterop": true,
+    "paths": {
+      "runner/*": ["../../../../../lib/rust/ensogl/pack/js/src/runner/*"]
+    }
   },
   "include": ["../types", "."]
 }

app/ide-desktop/lib/content-config/package.json

@@ -14,5 +14,8 @@
   },
   "bugs": {
     "url": "https://github.com/enso-org/enso/issues"
+  },
+  "scripts": {
+    "typecheck": "tsc --noEmit"
   }
 }

app/ide-desktop/lib/content/src/index.ts

@@ -7,7 +7,7 @@ import * as semver from 'semver'
 import * as authentication from 'enso-authentication'
 import * as contentConfig from 'enso-content-config'
 
-import * as app from '../../../../../target/ensogl-pack/linked-dist/index'
+import * as app from '../../../../../target/ensogl-pack/linked-dist'
 import GLOBAL_CONFIG from '../../../../gui/config.yaml' assert { type: 'yaml' }
 
 const logger = app.log.logger

app/ide-desktop/lib/types/modules.d.ts

@@ -2,6 +2,7 @@
  *
  * This file MUST NOT `export {}` for the modules to be visible to other files. */
 
+// Required because this is a build artifact and so would not otherwise work on a clean repository.
 declare module '*/build.json' {
     interface BuildInfo {
         commit: string
@@ -14,9 +15,35 @@ declare module '*/build.json' {
     export default BUILD_INFO
 }
 
+// Required because this is a build artifact and so would not otherwise work on a clean repository.
 declare module '*/ensogl-pack/linked-dist' {
-    // eslint-disable-next-line no-restricted-syntax
-    export * from '../../../../lib/rust/ensogl/pack/js/src/runner/index'
+    /* eslint-disable @typescript-eslint/consistent-type-imports, no-restricted-syntax, @typescript-eslint/no-shadow */
+    export type App = import('runner/index').App
+    export const App: typeof import('runner/index').App
+    export type Consumer = import('runner/index').Consumer
+    export const Consumer: typeof import('runner/index').Consumer
+    export type LogLevel = import('runner/index').LogLevel
+    export const LogLevel: typeof import('runner/index').LogLevel
+    export type Logger = import('runner/index').Logger
+    export const Logger: typeof import('runner/index').Logger
+    export type Option<T> = import('runner/index').Option<T>
+    export const Option: typeof import('runner/index').Option
+    export const log: typeof import('runner/index').log
+    export const logger: typeof import('runner/index').logger
+    export const urlParams: typeof import('runner/index').urlParams
+    export namespace config {
+        export type Option<T> = import('runner/index').config.Option<T>
+        export const Option: typeof import('runner/index').config.Option
+        export type Group<
+            Options extends OptionsRecord,
+            Groups extends GroupsRecord
+        > = typeof import('runner/index').config.Group<Options, Groups>
+        export const Group: typeof import('runner/index').config.Group
+        export const objectToGroup: typeof import('runner/index').config.objectToGroup
+        export const objectToOption: typeof import('runner/index').config.objectToOption
+        export const options: typeof import('runner/index').config.options
+    }
+    /* eslint-enable @typescript-eslint/consistent-type-imports, no-restricted-syntax, @typescript-eslint/no-shadow */
 }
 
 declare module '*/gui/config.yaml' {
@@ -75,7 +102,7 @@ declare module 'create-servers' {
 
     interface CreateServersOptions {
         http: number
-        handler: http.RequestListener<http.IncomingMessage, http.ServerResponse>
+        handler: http.RequestListener
     }
     interface HttpError {
         http: string

app/ide-desktop/lib/types/tsconfig.json

@@ -0,0 +1,4 @@
+{
+  "extends": "../../tsconfig.json",
+  "include": ["."]
+}

app/ide-desktop/package.json

@@ -36,6 +36,6 @@
     "watch": "npm run watch --workspace enso-content",
     "watch-dashboard": "npm run watch --workspace enso-dashboard",
     "build-dashboard": "npm run build --workspace enso-dashboard",
-    "typecheck": "npm run typecheck --workspace enso && npm run typecheck --workspace enso-content && npm run typecheck --workspace enso-dashboard && npm run typecheck --workspace enso-authentication"
+    "typecheck": "npx tsc --noEmit -p lib/types/tsconfig.json && npm run typecheck --workspace enso-content-config && npm run typecheck --workspace enso && npm run typecheck --workspace enso-content && npm run typecheck --workspace enso-dashboard && npm run typecheck --workspace enso-authentication"
   }
 }

app/ide-desktop/tsconfig.json

@@ -19,6 +19,9 @@
     "sourceMap": true,
     "skipLibCheck": true,
     "target": "ES2019",
-    "jsx": "react-jsx"
+    "jsx": "react-jsx",
+    "paths": {
+      "runner/*": ["../../lib/rust/ensogl/pack/js/src/runner/*"]
+    }
   }
 }

lib/rust/ensogl/pack/js/src/runner/config.ts

@@ -385,7 +385,11 @@ export function objectToGroup<T extends GroupObject>(
         }
     }
     const description = obj.description
-    return new Group({ description, options, groups }) as ToGroup<T>
+    return new Group({
+        ...(description ? { description } : {}),
+        ...(options ? { options } : {}),
+        ...(groups ? { groups } : {}),
+    }) as ToGroup<T>
 }
 
 /** Convert the plain option object to an `Option` object instance. */

lib/rust/ensogl/pack/js/src/runner/debug/help-screen.ts

@@ -12,7 +12,9 @@ export class HelpScreenSection {
     entries: HelpScreenEntry[]
     constructor(cfg: { name: string; description?: string; entries: HelpScreenEntry[] }) {
         this.name = cfg.name
-        this.description = cfg.description
+        if (cfg.description != null) {
+            this.description = cfg.description
+        }
         this.entries = cfg.entries
     }
 }
@@ -31,7 +33,9 @@ export class HelpScreenEntry {
     constructor(name: string, values: string[], href?: string) {
         this.name = name
         this.values = values
-        this.href = href
+        if (href != null) {
+            this.href = href
+        }
     }
 }
 

lib/rust/ensogl/pack/js/src/runner/log/logger.ts

@@ -250,7 +250,7 @@ export class Console extends Consumer {
             const coloredArgs: string[] = color ? strArgs.map(arg => Colors[color](arg)) : strArgs
             if (this.indentLvl > 0) {
                 const indent = this.indent()
-                const indentedArgs = coloredArgs.map(arg => arg.replaceAll('\n', `\n${indent}`))
+                const indentedArgs = coloredArgs.map(arg => arg.replace(/\n/g, `\n${indent}`))
                 c.log(this.indentShorter(), ...indentedArgs)
             } else {
                 c.log(...coloredArgs)