Adjusting tests to new parser #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
hubertp
reviewed
Mar 30, 2023
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala
Show resolved
Hide resolved
kazcw
reviewed
Mar 30, 2023
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SuspendedArgumentsTest.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/AliasAnalysisTest.scala
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala
Show resolved
Hide resolved
...e/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/ExpressionAnnotationsTest.scala
Outdated
Show resolved
Hide resolved
| @@ -89,14 +89,13 @@ class IgnoredBindingsTest extends CompilerTest { | |||
| } | |||
| } | |||
|
|
|||
| "Ignored bindings desugaring for bindings" ignore { | |||
| // FIXME: Not supported by new parser--needs triage (#5894). | |||
| "Ignored bindings desugaring for bindings" should { | |||
There was a problem hiding this comment.
The tree for _ = x looks reasonable, this syntax would need support in translation to be handled as before.
There was a problem hiding this comment.
Is it really reasonable? How can one use such _?
...ne/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala
Show resolved
Hide resolved
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/TypeSignaturesTest.scala
Outdated
Show resolved
Hide resolved
kazcw
approved these changes
Mar 31, 2023
JaroslavTulach
force-pushed
the
wip/jtulach/CompilerTestsUpdate_5894
branch
from
a15b1f2 to
ceaecc8
Compare
JaroslavTulach
added
the
CI: Ready to merge
JaroslavTulach
added
the
CI: Clean build required
hubertp
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Modification to various tests disabled when #5917 was integrated to pass with new parser. Fixes #5894.
Important Notes
Some tests can be fixed just by changes on the
IRside. Some (especially error simulating ones) would benefit from changes in theTreestructure or at least @kazcw evaluation.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.