Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21 compiler tests that relied on the old parser disabled #5894

Closed
kazcw opened this issue Mar 10, 2023 · 4 comments · Fixed by #6143
Closed

21 compiler tests that relied on the old parser disabled #5894

kazcw opened this issue Mar 10, 2023 · 4 comments · Fixed by #6143
Assignees
@JaroslavTulach
Labels
--breaking Important: a change that will break a public API or user-facing behaviour --bug Type: bug -compiler
Milestone
Design Partners

Comments

@kazcw
Copy link
Contributor

kazcw commented Mar 10, 2023 •
edited
Loading

Some backend tests that had not been switched to the new parser before #5917 don't pass with the new parser; these can be found by searching the codebase for references to this issue number (after that PR merges).

This is due to syntax cases that don't occur outside the tests in question, and that generally relate to type signatures and type declarations.

Each test either needs to be updated or needs a (generally simple) change in translation or the parser.
@kazcw kazcw closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2023
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Mar 10, 2023
kazcw added a commit that referenced this issue Mar 13, 2023
@kazcw
New doc parser. Parses in <2ms; simplifies codebase.
172ea43 
- Doc parsing is now done only in the frontend.
- The scala parser has been eliminated. We were using it for docs and a
  few odd cases, including to run some tests. Some syntax cases that
  only occurred in compiler tests are treated differently in the new
  parser. Mainly these relate to type signatures and annotations. Some
  of these cases should be handled in translation. #5894 tracks triaging
  these cases and re-enabling the affected tests.
- The option to run the old searcher has been removed, as it is obsolete
  and was already broken before this.
- Some interfaces used only by the old searcher have been removed.
@kazcw kazcw mentioned this issue Mar 13, 2023
Merged
5 tasks
@kazcw kazcw changed the title Placeholder Investigate backend tests that relied on the old parser Mar 13, 2023
@kazcw kazcw reopened this Mar 13, 2023
@github-project-automation github-project-automation bot moved this from 🟢 Accepted to ❓New in Issues Board Mar 13, 2023
mergify bot pushed a commit that referenced this issue Mar 15, 2023
@kazcw
New documentation parser (#5917)
e171fba 
Implement new Enso documentation parser; remove old Scala Enso parser.

Performance: Total time parsing documentation is now ~2ms.

# Important Notes
- Doc parsing is now done only in the frontend.
- Some engine tests had never been switched to the new parser. We should investigate tests that don't pass after the switch: #5894.
- The option to run the old searcher has been removed, as it is obsolete and was already broken before this (see #5909).
- Some interfaces used only by the old searcher have been removed.
@JaroslavTulach JaroslavTulach added this to the Design Partners milestone Mar 16, 2023
@JaroslavTulach
Copy link
Member

There seems to be 21 such tests right now:

enso$ grep -r 5894 engine/runtime/src/test/
engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/LambdaShorthandToLambdaTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/FunctionBindingTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/desugar/ComplexTypeTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/IgnoredBindingsTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/ExpressionAnnotationsTest.scala:    // FIXME: New parser handles the syntax error differently--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SugaredTypeFunctionsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/TypeSignaturesTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/TypeSignaturesTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SuspendedArgumentsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/resolve/SuspendedArgumentsTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/AliasAnalysisTest.scala:    // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Not supported by new parser--needs triage (#5894).
engine/runtime/src/test/scala/org/enso/compiler/test/pass/analyse/DataflowAnalysisTest.scala:      // FIXME: Different result in new parser!--needs triage (#5894).

CCing @hubertp

@JaroslavTulach JaroslavTulach changed the title Investigate backend tests that relied on the old parser 21 compiler tests that relied on the old parser disabled Mar 16, 2023
@JaroslavTulach JaroslavTulach added --breaking Important: a change that will break a public API or user-facing behaviour --bug Type: bug labels Mar 16, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 21, 2023
@JaroslavTulach JaroslavTulach mentioned this issue Mar 30, 2023
Merged
2 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 31, 2023 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2023-03-30):

Progress: - PR: #6143

Next Day: Continue analyzing disabled parser tests.

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@enso-bot
Copy link

enso-bot bot commented Apr 1, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-03-31):

Progress: - Review: #6154

Next Day: Continue analyzing disabled parser tests.

@enso-bot
Copy link

enso-bot bot commented Apr 2, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-01):

Progress: - parser tests - got SuspendedArgumentsTest working: 0dbe636
- parser tests: 487620f
- TypeSignaturesTest fixed
- EnsoProject bugfix: 1433847 It should be finished by 2023-04-03.

Next Day: BookClub.

@mergify mergify bot closed this as completed in #6143 Apr 2, 2023
mergify bot pushed a commit that referenced this issue Apr 2, 2023
@JaroslavTulach
Adjusting tests to new parser (#6143)
0d7682b 
Modification to various tests disabled when #5917 was integrated to pass with new parser. Fixes #5894.

# Important Notes
Some tests can be fixed just by changes on the `IR` side. Some (especially error simulating ones) would benefit from changes in the `Tree` structure or at least @kazcw evaluation.
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
--breaking Important: a change that will break a public API or user-facing behaviour --bug Type: bug -compiler
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Adjusting tests to new parser enso-org/enso
2 participants
@kazcw @JaroslavTulach