Treat Boolean.False as false primitive #6090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6076
Pull Request Description
Treat
Boolean.False
andBoolean.True
as the corresponding primitives. Now,Boolean.False == False
returns true.Important Notes
False
andTrue
constructs, that are converted toConstructorNode
during Truffle codegen, are handled specially inConstructorNode
. The easiest fix was to implement a similar special handling inQualifiedAccessorNode
, although not the cleanest one.A better solution would be to provide transformation of
Boolean.True
IR to a true literal inApplicationSaturation
compiler pass. ButApplicationSaturation
pass does not handleTrue
. Moreover, for our case, it is unnecessarily complicated.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.