Boolean.False == False is false

[jdunkerley]

The dropdown puts in Boolean.True and Boolean.False. There is a problem that Boolean.False != False.

[jdunkerley]

Possibly related:

[warn] [2023-03-25T15:55:24.566Z] [enso] Execution of function main failed (class org.enso.interpreter.runtime.callable.atom.BoxingAtom cannot be cast to class java.lang.Boolean (org.enso.interpreter.runtime.callable.atom.BoxingAtom is in unnamed module of loader com.oracle.graalvm.locator.GraalVMLocator$GuestLangToolsLoader @7ac9af2a; java.lang.Boolean is in module java.base of loader 'bootstrap')).
java.lang.ClassCastException: Some(class org.enso.interpreter.runtime.callable.atom.BoxingAtom cannot be cast to class java.lang.Boolean (org.enso.interpreter.runtime.callable.atom.BoxingAtom is in unnamed module of loader com.oracle.graalvm.locator.GraalVMLocator$GuestLangToolsLoader @7ac9af2a; java.lang.Boolean is in module java.base of loader 'bootstrap'))

[JaroslavTulach]

Thanks @Akirathan for taking a look.

[Akirathan]

Possibly related:

I guess you mean exactly this:

> False.not
>>> true
> Boolean.False.not
Evaluation failed with: class org.enso.interpreter.runtime.callable.atom.BoxingAtom cannot be cast to class java.lang.Boolean (org.enso.interpreter.runtime.callable.atom.BoxingAtom is in unnamed module of loader com.oracle.graalvm.locator.GraalVMLocator$GuestLangToolsLoader @27912e3; java.lang.Boolean is in module java.base of loader 'bootstrap')

Does not seem related at first sight, because that is failing due to the casting done through invocation. Moreover, I tried running that snippet on engine from 12/2022, and it was still failing, so this issue is an old one.

> Boolean.False == False
>>> false

I will fix that, should be pretty much straightforward. The problem is that Boolean.False is an atom, whereas False is a literal value.

[JaroslavTulach]

The problem is that Boolean.False is an atom, whereas False is a literal value.

The best fix is to make sure Boolean.False also resolves to a literal value, if possible.

[enso-bot]

Pavel Marek reports a new STANDUP for today (2023-03-27):

Progress: Fixing the special handling for Boolean.False. Tried to do that "properly" via ApplicationSaturation compler phase, but gave that up after some time - Both False and Boolean.False could be just transformed to false literal in the IR, so that we don't have to special handling during runtime. It should be finished by 2023-03-28.