Add Table.union to the In-Memory Table.
#4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
commented
Jan 14, 2023
radeusgd
commented
Jan 14, 2023
radeusgd
force-pushed
the
wip/radeusgd/table-union-183854144
branch
from
ce37c49 to
dcfabcd
Compare
jdunkerley
approved these changes
Jan 16, 2023
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/column/builder/object/TypedBuilderImpl.java
Show resolved
Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Match_Columns.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Match_Columns.enso
Outdated
Show resolved
Hide resolved
Comment on lines
1188
to
1189
| is_everything_ok = tables_vector.all table-> | ||
| if Table_Helpers.is_table table . not then Error.throw (Type_Error.Error Table table "tables") else |
There was a problem hiding this comment.
I'd be tempted to put this into Table_Helpers to make this read clearer as a lot going on in this function.
There was a problem hiding this comment.
The Table Helpers are primarily backend-agnostic and this is a backend-specific check, so instead I moved it into a private method in the Table module.
radeusgd
force-pushed
the
wip/radeusgd/table-union-183854144
branch
2 times, most recently
from
34fc258 to
46432e2
Compare
radeusgd
force-pushed
the
wip/radeusgd/table-union-183854144
branch
from
3914dd5 to
474ecf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/183854144
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.