Skip to content

Commit

Permalink
Update docs
Browse files Browse the repository at this point in the history
  • Loading branch information
radeusgd committed Jan 14, 2023
1 parent 4f35eeb commit ce37c49
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
12 changes: 7 additions & 5 deletions distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Original file line number Diff line number Diff line change
Expand Up @@ -810,8 +810,10 @@ type Table
the section "Unifying Column Types" below. If set to `False` the
resulting column type will be the same as in the first table the
corresponding column appeared in (usually `self`, except for unmatched
columns). If types of corresponding columns from other tables will be
incompatible with it, a `Column_Type_Mismatch` is reported.
columns). If type widening is not allowed, all columns that are merged
with each other must have the same type as the first one. The only
exception is if the first column had `Mixed` type which will accept any
other type.
- on_problems: Specifies how to handle problems if they occur, reporting
them as warnings by default.

Expand All @@ -832,9 +834,9 @@ type Table
type that is incompatible with the type coming from the first table,
a `Column_Type_Mismatch` is reported. The problematic column will be
dropped from the resulting table. With type widening disabled, the
only coercion that is allowed is coercing integers to a column
expecting decimals. Any other coercions, like boolean to integer, are
not allowed.
subsequent tables must have the same types as the first one, unless
the type of the first one was `Mixed` which will accept any other
type.
- If a common type coercion for a set of matched columns from
concatenated tables cannot be found, a `No_Common_Type` is reported.
In warning or ignore mode, the problematic column will be dropped
Expand Down
13 changes: 7 additions & 6 deletions distribution/lib/Standard/Table/0.0.0-dev/src/Data/Table.enso
Original file line number Diff line number Diff line change
Expand Up @@ -1128,8 +1128,10 @@ type Table
the section "Unifying Column Types" below. If set to `False` the
resulting column type will be the same as in the first table the
corresponding column appeared in (usually `self`, except for unmatched
columns). If types of corresponding columns from other tables will be
incompatible with it, a `Column_Type_Mismatch` is reported.
columns). If type widening is not allowed, all columns that are merged
with each other must have the same type as the first one. The only
exception is if the first column had `Mixed` type which will accept any
other type.
- on_problems: Specifies how to handle problems if they occur, reporting
them as warnings by default.

Expand All @@ -1150,9 +1152,9 @@ type Table
type that is incompatible with the type coming from the first table,
a `Column_Type_Mismatch` is reported. The problematic column will be
dropped from the resulting table. With type widening disabled, the
only coercion that is allowed is coercing integers to a column
expecting decimals. Any other coercions, like boolean to integer, are
not allowed.
subsequent tables must have the same types as the first one, unless
the type of the first one was `Mixed` which will accept any other
type.
- If a common type coercion for a set of matched columns from
concatenated tables cannot be found, a `No_Common_Type` is reported.
In warning or ignore mode, the problematic column will be dropped
Expand Down Expand Up @@ -1194,7 +1196,6 @@ type Table
True or will contain a dataflow error which will propagate through
the if statement.
if is_everything_ok then
## TODO problem handling
all_tables = [self] + tables_vector
problem_builder = Problem_Builder.new
matched_column_sets = Match_Columns_Helpers.match_columns all_tables match_columns keep_unmatched_columns problem_builder
Expand Down

0 comments on commit ce37c49

Please sign in to comment.