Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct IR.Syntax.Error rather than throwing an exception #3861

Merged
merged 8 commits into from
Nov 10, 2022
Merged

Construct IR.Syntax.Error rather than throwing an exception #3861

merged 8 commits into from
Nov 10, 2022

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Nov 9, 2022 •
edited
Loading

Pull Request Description

This PR mimics test cases from #3860 and makes sure IR.Syntax.Error is constructed at appropriate places rather than just yielding an UnhandledEntity exception.

Important Notes

Merge before #3611 to minimize disruption when changing the parser.

Checklist

Please include the following checklist in your PR:

  • All code conforms to the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 9, 2022
@JaroslavTulach JaroslavTulach requested a review from kazcw November 9, 2022 08:40
@JaroslavTulach JaroslavTulach self-assigned this Nov 9, 2022
@JaroslavTulach JaroslavTulach mentioned this pull request Nov 9, 2022
Merged
3 tasks
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Nov 10, 2022
@mergify mergify bot merged commit 20686dd into develop Nov 10, 2022
@mergify mergify bot deleted the wip/jtulach/ErrorsInIr_183740897 branch November 10, 2022 09:06
@wdanilo wdanilo mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@kazcw kazcw Awaiting requested review from kazcw

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroslavTulach @hubertp