Ensure parses of invalid inputs represent all tokens #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
wdanilo
approved these changes
Nov 8, 2022
JaroslavTulach
approved these changes
Nov 9, 2022
| test_invalid("polyglot java import"); | ||
| test_invalid("from import all"); | ||
| test_invalid("from Foo import all hiding"); | ||
| test_invalid("from Foo import all hiding X.Y"); |
There was a problem hiding this comment.
Handling the previous tests by b8f9124 - the following tests are rather malformed_export ones, btw.
However there is no IR.Error.Syntax.InvalidExport, just InvalidImport, so I am using it in: 6df12fa as well. Probably using such reason may not matter much as it is mostly an internal object not shown to the user.
However the error messages are still "Imports must have a valid path." and if shown to users, they may get confused by that.
2 tasks
| test_invalid("foreign 4 * 4"); | ||
| test_invalid("foreign foo = \"4\""); | ||
| test_invalid("foreign js foo = 4"); | ||
| } |
There was a problem hiding this comment.
All tests in this file were converted into https://github.com/enso-org/enso/blob/e9227323a2aada032e376fd2cf8891f1ab94fd3c/engine/runtime/src/test/java/org/enso/compiler/ErrorCompilerTest.java and are handled appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Ensure all tokens from the input are represented in trees resulting from invalid inputs--tests now cover every reachable code line that creates an
Invalidnode. (Also implemented stricter validation, mainly ofimport/exportstatements.)See: https://www.pivotaltracker.com/story/show/183405907
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.