Documenting how to build the IDE #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
MichaelMauderer,
wdanilo,
4e6 and
PabloBuchu
as code owners
JaroslavTulach
commented
Apr 8, 2022
JaroslavTulach
changed the title
jtulach
force-pushed
the
jtulach/BuildingTheIDE
branch
2 times, most recently
from
0cea95e to
3811a31
Compare
JaroslavTulach
changed the title
jtulach
force-pushed
the
jtulach/BuildingTheIDE
branch
from
3811a31 to
5841265
Compare
JaroslavTulach
changed the title
farmaazon
reviewed
Apr 12, 2022
There was a problem hiding this comment.
I tested the last fixes, and indeed, all commands I know works.
I'm not sure if the last @JaroslavTulach comment is a problem or not? Can we force-merge it ASAP @wdanilo or @MichaelMauderer ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci no changelog needed]
Pull Request Description
The first change 5c0f82c provides falsification to #3386 - if the
--skip-version-validationargument is missing - the validation is really performed.It took me a while to realize what Rust tools to install. @4e6 hinted me via chat, but it is probably better to mention that in the documentation: 8100ec9 - @MichaelMauderer suggested to link to IDE guide: a4b817b and last but not least, I added an argument to avoid log masking when running
project-manager: 3811a31Checklist
Please include the following checklist in your PR:
--skip-version-validationargument the build really fails on my systemsPlease accept my apology for not checking the behavior without the option in #3386