Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --skip-version-validation option before passing the args on #3386

Merged

Conversation

JaroslavTulach
Copy link
Member

Pull Request Description

I am trying to build and run the IDE. When I use following command, help gets printed and then an error:

$ ./run --skip-version-validation build --dev
...
Not enough non-option arguments: got 0, need at least 1

I believe this is caused by --skip-version-validation being propagated where it shouldn't.

Checklist

Please include the following checklist in your PR:

All code conforms to the ... style guidelines.

A JavaScript guideline would suggest use of ; at the end of line. However I am adding lines without ; to be consistent with current style used in the file.

@wdanilo
Copy link
Member

wdanilo commented Apr 7, 2022

Good catch!

@wdanilo
Copy link
Member

wdanilo commented Apr 7, 2022

Regarding ; at the end of the line, no one writes JS this way anymore. Also, we are soon removing these scripts because we have a new version in Rust almost ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants