-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color edges according to source node. #11810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
requested review from
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
December 9, 2024 13:35
🧪 Storybook is successfully deployed!📊 Dashboard:
|
kazcw
approved these changes
Dec 9, 2024
jdunkerley
pushed a commit
that referenced
this pull request
Dec 10, 2024
Fixes #11536 <img width="238" alt="image" src="https://github.com/user-attachments/assets/e253b188-a6ce-468f-864c-9e814a8a2584"> Also fixed incorrect edge offset when dragging an target-connected edge. <img width="140" alt="image" src="https://github.com/user-attachments/assets/d75ac860-c614-4f40-9cbc-b955e94f5a58"> (cursor painted in, because it wasn't captured by the screenshot 😅) # Important Notes Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now. (cherry picked from commit 7e47a65)
jdunkerley
pushed a commit
that referenced
this pull request
Dec 10, 2024
Fixes #11536 <img width="238" alt="image" src="https://github.com/user-attachments/assets/e253b188-a6ce-468f-864c-9e814a8a2584"> Also fixed incorrect edge offset when dragging an target-connected edge. <img width="140" alt="image" src="https://github.com/user-attachments/assets/d75ac860-c614-4f40-9cbc-b955e94f5a58"> (cursor painted in, because it wasn't captured by the screenshot 😅) # Important Notes Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now. (cherry picked from commit 7e47a65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #11536
Also fixed incorrect edge offset when dragging an target-connected edge.
(cursor painted in, because it wasn't captured by the screenshot 😅)Important Notes
Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.