Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color edges according to source node. #11810

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Dec 9, 2024

Pull Request Description

Fixes #11536

image

Also fixed incorrect edge offset when dragging an target-connected edge.

image (cursor painted in, because it wasn't captured by the screenshot 😅)

Important Notes

Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Copy link

github-actions bot commented Dec 9, 2024

🧪 Storybook is successfully deployed!

📊 Dashboard:

@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Dec 9, 2024
@mergify mergify bot merged commit 7e47a65 into develop Dec 9, 2024
45 of 48 checks passed
@mergify mergify bot deleted the wip/frizi/edge-color-from-source branch December 9, 2024 15:29
jdunkerley pushed a commit that referenced this pull request Dec 10, 2024
Fixes #11536

<img width="238" alt="image" src="https://github.com/user-attachments/assets/e253b188-a6ce-468f-864c-9e814a8a2584">

Also fixed incorrect edge offset when dragging an target-connected edge.

<img width="140" alt="image" src="https://github.com/user-attachments/assets/d75ac860-c614-4f40-9cbc-b955e94f5a58">
(cursor painted in, because it wasn't captured by the screenshot 😅)

# Important Notes
Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now.

(cherry picked from commit 7e47a65)
jdunkerley pushed a commit that referenced this pull request Dec 10, 2024
Fixes #11536

<img width="238" alt="image" src="https://github.com/user-attachments/assets/e253b188-a6ce-468f-864c-9e814a8a2584">

Also fixed incorrect edge offset when dragging an target-connected edge.

<img width="140" alt="image" src="https://github.com/user-attachments/assets/d75ac860-c614-4f40-9cbc-b955e94f5a58">
(cursor painted in, because it wasn't captured by the screenshot 😅)

# Important Notes
Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now.

(cherry picked from commit 7e47a65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph Editor Look&Feel - the colour of the edges is from the source, not the target.
2 participants