Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph Editor Look&Feel - the colour of the edges is from the source, not the target. #11536

Closed
Tracked by #11510
farmaazon opened this issue Nov 12, 2024 · 0 comments · Fixed by #11810
Closed
Tracked by #11510

Graph Editor Look&Feel - the colour of the edges is from the source, not the target. #11536

farmaazon opened this issue Nov 12, 2024 · 0 comments · Fixed by #11810
Assignees
@Frizi
Labels
-gui
Milestone
2024-12 Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Nov 12, 2024 •
edited
Loading

If there is no source, the edge should be gray.

Connections from the selected nodes should be in the lighter color.
@farmaazon farmaazon mentioned this issue Nov 12, 2024
Closed
@farmaazon farmaazon changed the title The colour of the edges is from the source, not the target. If there is no source, the edge should be gray. - (1) Graph Editor Look&Feel - the colour of the edges is from the source, not the target. Nov 12, 2024
@farmaazon farmaazon added this to the 2024-12 Release milestone Nov 12, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Nov 12, 2024
@farmaazon farmaazon added the -gui label Dec 5, 2024
@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board Dec 9, 2024
@Frizi Frizi mentioned this issue Dec 9, 2024
Merged
5 tasks
@Frizi Frizi moved this from 🔧 Implementation to 👁️ Code review in Issues Board Dec 9, 2024
@mergify mergify bot closed this as completed in #11810 Dec 9, 2024
@mergify mergify bot closed this as completed in 7e47a65 Dec 9, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 9, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Dec 10, 2024
jdunkerley pushed a commit that referenced this issue Dec 10, 2024
@Frizi @jdunkerley
Color edges according to source node. (#11810)
7659522 
Fixes #11536

<img width="238" alt="image" src="https://github.com/user-attachments/assets/e253b188-a6ce-468f-864c-9e814a8a2584">

Also fixed incorrect edge offset when dragging an target-connected edge.

<img width="140" alt="image" src="https://github.com/user-attachments/assets/d75ac860-c614-4f40-9cbc-b955e94f5a58">
(cursor painted in, because it wasn't captured by the screenshot 😅)

# Important Notes
Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now.

(cherry picked from commit 7e47a65)
jdunkerley pushed a commit that referenced this issue Dec 10, 2024
@Frizi @jdunkerley
Color edges according to source node. (#11810)
7abc1c7 
Fixes #11536

<img width="238" alt="image" src="https://github.com/user-attachments/assets/e253b188-a6ce-468f-864c-9e814a8a2584">

Also fixed incorrect edge offset when dragging an target-connected edge.

<img width="140" alt="image" src="https://github.com/user-attachments/assets/d75ac860-c614-4f40-9cbc-b955e94f5a58">
(cursor painted in, because it wasn't captured by the screenshot 😅)

# Important Notes
Split away edge layout code away from the component to separate file. That code is likely to be significantly changed soon, but no significant modifications were made right now.

(cherry picked from commit 7e47a65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
-gui
Projects
Issues Board
Status: 🗄️ Archived
Milestone
2024-12 Release
Development

Successfully merging a pull request may close this issue.

Color edges according to source node. enso-org/enso
2 participants
@Frizi @farmaazon