Occurences in Java. Don't expose setters for Scope vars. #11464
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| package org.enso.compiler.pass.analyse.alias.graph; | ||
|
|
||
| import java.util.UUID; | ||
| import org.enso.compiler.core.ExternalID; | ||
| import org.enso.compiler.core.Identifier; | ||
|
|
||
| /** | ||
| * An occurrence of a given symbol in the aliasing graph. Note that this is not present in the | ||
| * metadata attached to the [[org.enso.compiler.core.IR]] elements, but only in the alias [[Graph]]. | ||
| */ | ||
| public sealed interface GraphOccurrence permits GraphOccurrence.Def, GraphOccurrence.Use { | ||
| public abstract int id(); | ||
|
|
||
| public abstract String symbol(); | ||
|
|
||
| /** The definition of a symbol in the aliasing graph. */ | ||
| public static final class Def implements GraphOccurrence { | ||
| private final int id; | ||
| private final String symbol; | ||
| private final @Identifier UUID identifier; | ||
| private final @ExternalID UUID externalId; | ||
| private final boolean isLazy; | ||
|
|
||
| /** | ||
| * The definition of a symbol in the aliasing graph. | ||
| * | ||
| * @param id the identifier of the name in the graph | ||
| * @param symbol the text of the name | ||
| * @param identifier the identifier of the symbol | ||
| * @param externalId the external identifier for the IR node defining the symbol | ||
| * @param isLazy whether or not the symbol is defined as lazy | ||
| */ | ||
| public Def( | ||
| int id, String symbol, UUID identifier, scala.Option<UUID> externalId, boolean isLazy) { | ||
| this.id = id; | ||
| this.externalId = externalId.nonEmpty() ? externalId.get() : null; | ||
| this.identifier = identifier; | ||
| this.isLazy = isLazy; | ||
| this.symbol = symbol; | ||
| } | ||
|
|
||
| public Def(int id, String symbol, UUID identifier, scala.Option<UUID> externalId) { | ||
| this(id, symbol, identifier, externalId, false); | ||
| } | ||
|
|
||
| @Override | ||
| public int id() { | ||
| return this.id; | ||
| } | ||
|
|
||
| @Override | ||
| public String symbol() { | ||
| return this.symbol; | ||
| } | ||
|
|
||
| public UUID identifier() { | ||
| return identifier; | ||
| } | ||
|
|
||
| public scala.Option<UUID> externalId() { | ||
| return scala.Option.apply(externalId); | ||
| } | ||
|
|
||
| public boolean isLazy() { | ||
| return isLazy; | ||
| } | ||
|
|
||
| public static scala.Option<scala.Tuple5<Integer, String, UUID, scala.Option<UUID>, Boolean>> | ||
| unapply(Object obj) { | ||
| if (obj instanceof Def d) { | ||
| var extId = scala.Option.apply(d.externalId); | ||
| var tuple = new scala.Tuple5<>(d.id, d.symbol, d.identifier, extId, d.isLazy); | ||
| return scala.Option.apply(tuple); | ||
| } | ||
| return scala.Option.empty(); | ||
| } | ||
| } | ||
|
|
||
| /** A usage of a symbol in the aliasing graph */ | ||
| public static final class Use implements GraphOccurrence { | ||
| private final int id; | ||
| private final String symbol; | ||
| private final @Identifier UUID identifier; | ||
| private final @ExternalID UUID externalId; | ||
|
|
||
| /** | ||
| * A usage of a symbol in the aliasing graph | ||
| * | ||
| * <p>Name usages _need not_ correspond to name definitions, as dynamic symbol resolution means | ||
| * that a name used at runtime _may not_ be statically visible in the scope. | ||
| * | ||
| * @param id the identifier of the name in the graph | ||
| * @param symbol the text of the name | ||
| * @param identifier the identifier of the symbol | ||
| * @param externalId the external identifier for the IR node defining the symbol | ||
| */ | ||
| public Use(int id, String symbol, UUID identifier, scala.Option<UUID> externalId) { | ||
| this.id = id; | ||
| this.symbol = symbol; | ||
| this.externalId = externalId.nonEmpty() ? externalId.get() : null; | ||
| this.identifier = identifier; | ||
| } | ||
|
|
||
| @Override | ||
| public int id() { | ||
| return this.id; | ||
| } | ||
|
|
||
| @Override | ||
| public String symbol() { | ||
| return this.symbol; | ||
| } | ||
|
|
||
| public UUID identifier() { | ||
| return identifier; | ||
| } | ||
|
|
||
| public scala.Option<UUID> externalId() { | ||
| return scala.Option.apply(externalId); | ||
| } | ||
|
|
||
| public static scala.Option<scala.Tuple4<Integer, String, UUID, scala.Option<UUID>>> unapply( | ||
| Object obj) { | ||
| if (obj instanceof Use u) { | ||
| var extId = scala.Option.apply(u.externalId); | ||
| var tuple = new scala.Tuple4<>(u.id, u.symbol, u.identifier, extId); | ||
| return scala.Option.apply(tuple); | ||
| } | ||
| return scala.Option.empty(); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not declare it as record? It used to be
sealed case classin Scala.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with
recordis that all (default) constructor fields are publicly accessible. I plan to control the encapsulation more in some subsequent changes. Thus I went the more verbose way and created aclass.