Occurences in Java. Don't expose setters for Scope vars.

[JaroslavTulach]

Pull Request Description

Another change motivated by work on #11365. Continuation of #11419.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• All code follows the
  Scala,
• Unit tests have been written where possible.

[Akirathan]

Why not declare it as record? It used to be sealed case class in Scala.

[JaroslavTulach]

The problem with record is that all (default) constructor fields are publicly accessible. I plan to control the encapsulation more in some subsequent changes. Thus I went the more verbose way and created a class.

[Akirathan]

I don't understand the purpose of this refactoring. Why not simply define these fields as private var childScopes: List[Scope] = ... without the rename and define public plain old getters?

[hubertp]

I'm only guessing but it looks like he wanted to limit the scope of variables so that one does not accidentally mutate them? But yes, the motivation is unclear.

[JaroslavTulach]

The title of this PR is:

Don't expose setters for Scope vars.

Renaming the fields to private var _xyz and adding def xyz = _xyz achieves that goal. If there is a better way in Scala to have public getters, but private setters, feel free to propose it.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for today (2024-11-01):

Progress: .

- Summary of vacation work
- Mon:
   - benchmarks aren't compiling: 
   - no `Scope.flattenToParent`: 
- Tue:
   - PR integrated: https://github.com/enso-org/enso/pull/11393
   - Cannot have argument b and local variable b anymore: 
   - Give IfThenElseNode a location: 

- Thu:
   - talking with Pavel about `IfThenElse` scopes
   - trying various approaches to scopes
   - more of encapsulation: https://github.com/enso-org/enso/pull/11464
   - rewriting `GraphOccurrence` to Java: 

- Fri:
   - Fixing `runtime-integration-tests`:
   - PR integrated: https://github.com/enso-org/enso/pull/11464 It should be finished by 2024-11-04.

Next Day: Vacation is over. Back to work.