Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove akka dependencies from runtime project #8222

Closed
3 tasks done
Akirathan opened this issue Nov 3, 2023 · 8 comments · Fixed by #8953
Closed
3 tasks done

Remove akka dependencies from runtime project #8222

Akirathan opened this issue Nov 3, 2023 · 8 comments · Fixed by #8953
Assignees
Labels
-compiler d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-chore Type: chore

Comments

@Akirathan
Copy link
Member

Akirathan commented Nov 3, 2023

runtime project, and thus runtime.jar fat jar, transitively contains akka dependencies, for example from runtime --> downloader --> akka. We should remove akka from downloader and implement the downloading by some simple http component from JDK (or Scala's standard library).

akka is unnecessarily heavy-weight, it comprises of a lot of classes that are loaded just because of few simple HTTP requests.

Tasks

Preview Give feedback
@Akirathan Akirathan added d-intermediate Difficulty: some prior knowledge required x-chore Type: chore -compiler labels Nov 3, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Nov 3, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Nov 7, 2023
@Akirathan Akirathan added the p-medium Should be completed in the next few sprints label Feb 1, 2024
@Akirathan Akirathan moved this from 📤 Backlog to ⚙️ Design in Issues Board Feb 2, 2024
@Akirathan Akirathan mentioned this issue Feb 2, 2024
5 tasks
@enso-bot
Copy link

enso-bot bot commented Feb 2, 2024

Pavel Marek reports a new STANDUP for today (2024-02-02):

Progress: - Started to look into how to remove the akka dependencies from various places under runtime project.

GitHub
Closes #8601 Pull Request Description This PR provides following fixes:

speed runEngineDistribution up by proper time stampingruntime.jar and avoiding it to be re-built with every execution
allow...

@enso-bot
Copy link

enso-bot bot commented Feb 8, 2024

Pavel Marek reports a new STANDUP for today (2024-02-08):

Progress: - Seems like I am almost done with the migration to JDK HTTP client and virtual thread executor.

  • Fixing library-manager-test. It should be finished by 2024-02-12.

@enso-bot
Copy link

enso-bot bot commented Feb 9, 2024

Pavel Marek reports a new STANDUP for today (2024-02-09):

Progress: - library-manager-test already passes.

  • Trying to add tests of the downloader with http-test-helper It should be finished by 2024-02-12.

@Akirathan Akirathan moved this from ⚙️ Design to 🔧 Implementation in Issues Board Feb 12, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 13, 2024

Pavel Marek reports a new STANDUP for yesterday (2024-02-12):

Progress: - Creating tests and implementing task progress

  • Refactored http-test-helper to be able to run it as an embedded server, rather than a subprocess. It should be finished by 2024-02-12.

@enso-bot
Copy link

enso-bot bot commented Feb 15, 2024

Pavel Marek reports a new 🔴 DELAY for today (2024-02-15):

Summary: There is 10 days delay in implementation of the Remove akka dependencies from runtime project (#8222) task.
It will cause 10 days delay for the delivery of this weekly plan.

Will probably have to refactor that PR to use Apache HttpClient instead of pure JDK.

Delay Cause: Issue with native image build on Windows, also, peers don't like the custom usage of JDK

@enso-bot
Copy link

enso-bot bot commented Feb 15, 2024

Pavel Marek reports a new STANDUP for today (2024-02-15):

Progress: - native image build of launcher is failing on Windows, but works on Linux.

  • Radek cannot reproduce that on his Windows machine.
  • Let's increase logging and see what is wrong on the CI.
  • Ongoing discussion about using Apache Http rather than pure JDK solution. It should be finished by 2024-02-22.

@enso-bot
Copy link

enso-bot bot commented Feb 16, 2024

Pavel Marek reports a new STANDUP for today (2024-02-16):

Progress: - Still cannot figure out the native image build failure on Windows.

  • Capturing output from the native image build, increasing verbosity, restarting the job... It should be finished by 2024-02-22.

@mergify mergify bot closed this as completed in #8953 Feb 19, 2024
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Feb 19, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 19, 2024

Pavel Marek reports a new STANDUP for today (2024-02-19):

Progress: - The build failure on the Windows was caused by the cmd line being too long.

  • Fixed by adding arguments to native-image via an argument file.
  • Finally merged. It should be finished by 2024-02-22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-chore Type: chore
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant