Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Akka Http back to Apache HttpClient #8934

Closed
hubertp opened this issue Feb 1, 2024 · 1 comment
Closed

Replace Akka Http back to Apache HttpClient #8934

hubertp opened this issue Feb 1, 2024 · 1 comment

Comments

@hubertp
Copy link
Collaborator

hubertp commented Feb 1, 2024

Back in #1169 we replaced Apache HttpClient with Akka Http:

  1. Central logging was the main motivation
  2. We were already using Akka, so one less dependency

We are coming full circle because it seems we should get back to it.
Re 1: that's no longer valid given our implementation that is based on slf4j.
Re 2: eventually Akka will go

Using Akka Http is not wrong on its own but the current implementation is problematic since we are not terminating the system.
This leads to resource usage (#8806) in tests:
Screenshot from 2024-02-01 17-04-25

@Akirathan
Copy link
Member

Since JDK provides HttpClient capable of handling HTTP requests, I would restrain from using the Apache's httpclient. No need to add yet another dependency. In #8222, I am already migrating the downloader project to JDK's httpclient.

@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants