You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Back in #1169 we replaced Apache HttpClient with Akka Http:
Central logging was the main motivation
We were already using Akka, so one less dependency
We are coming full circle because it seems we should get back to it.
Re 1: that's no longer valid given our implementation that is based on slf4j.
Re 2: eventually Akka will go
Using Akka Http is not wrong on its own but the current implementation is problematic since we are not terminating the system.
This leads to resource usage (#8806) in tests:
The text was updated successfully, but these errors were encountered:
Since JDK provides HttpClient capable of handling HTTP requests, I would restrain from using the Apache's httpclient. No need to add yet another dependency. In #8222, I am already migrating the downloader project to JDK's httpclient.
Back in #1169 we replaced Apache HttpClient with Akka Http:
We are coming full circle because it seems we should get back to it.
Re 1: that's no longer valid given our implementation that is based on slf4j.
Re 2: eventually Akka will go
Using Akka Http is not wrong on its own but the current implementation is problematic since we are not terminating the system.
This leads to resource usage (#8806) in tests:
The text was updated successfully, but these errors were encountered: