IDE is not able to reconnect to engine after waking up from suspend/hibernation #7729
Comments
hubertp
added a commit
that referenced
this issue
Sep 12, 2023
This PR addresses problems mentioned in #7470 and #7729: - shutting a language server explicitly will not lead to a soft shutdown - `project/status` endpoint returns the state of the language server `LanguageServerController` now also signed up for `ClientConnect` messages. For it to be unambiguous, we need to carry around the port number of the language server as a way of identifying the right one. One can now use `project/status` to additionally determine the state of the language server. Also relies on a proper fix for #7765.
3 tasks
hubertp
added a commit
that referenced
this issue
Sep 19, 2023
This PR addresses problems mentioned in #7470 and #7729: - shutting a language server explicitly will not lead to a soft shutdown - `project/status` endpoint returns the state of the language server `LanguageServerController` now also signed up for `ClientConnect` messages. For it to be unambiguous, we need to carry around the port number of the language server as a way of identifying the right one. One can now use `project/status` to additionally determine the state of the language server. Also relies on a proper fix for #7765.
hubertp
added a commit
that referenced
this issue
Sep 22, 2023
* Improve shutdown logic of language server This PR addresses problems mentioned in #7470 and #7729: - shutting a language server explicitly will not lead to a soft shutdown - `project/status` endpoint returns the state of the language server `LanguageServerController` now also signed up for `ClientConnect` messages. For it to be unambiguous, we need to carry around the port number of the language server as a way of identifying the right one. One can now use `project/status` to additionally determine the state of the language server. Also relies on a proper fix for #7765. * changelog * PR comments
|
Done with #7801 |
github-project-automation
bot
moved this from 👁️ Code review
to 🟢 Accepted
in Issues Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The feature has been added on the engine side #5197 but has regressed some time since:
The client (IDE) will a) disconnect from LS and project manager when waking up b) attempt, after a brief moment, to reconnect to the same port.
The fix for #5197 introduced a delay so that we wouldn't shutdown LS immediately. Rather we would allow LS to live for a brief moment waiting on any new connections, thus allowing clients to re-connect to the same port.
This has regressed partially via #7699 but reverting it is not sufficient to bring the functionality back.
Related to #5202 and #7470
The text was updated successfully, but these errors were encountered: