Resuming from hibernation crashes the application (Windows) #11389
Comments
|
Adam Obuchowicz reports a new STANDUP for today (2024-10-31): Progress: Fought much with setting up/updating the Windows setup. Checked that linux is fine. Discovered that it is LS who turns itself down after apparent disconnection from the client (and client crashes as it cannot connect to engine anymore). It should be finished by 2024-11-08. Next Day: Next day I will be working on the #11389 task. Think and discuss how could be done with above. |
|
I will test it as well on some old WIndows machine |
|
Adam Obuchowicz reports a new STANDUP for yesterday (2024-11-04): Progress: As the Language Server seems to be closed immediately instead of waiting for further reconnections, I left that part to Hubert. Tried to add exception handling, so electron app at least won't crash It should be finished by 2024-11-08. Next Day: Next day I will be working on the same task. Try to finish this task and take next one |
|
I can confirm. From the logs it looks like something requests a shutdown. Will investigate. For the moment unassigning GUI unless I confirm otherwise. |
|
This has been fixed a while ago, at least the backend part, in
So it appears to be a regression. On the other hand, it does not seem to trigger the delayed shutdown logic and it only happens on Windows, so could be a new bug. |
|
Hubert Plociniczak reports a new STANDUP for yesterday (2024-11-05): Progress: Adding more docs to #11265. Reproduced #11389 and investigating. It should be finished by 2024-11-08. Next Day: Next day I will be working on the #11389 task. Address PR review, look into hibernation issues. |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-06): Progress: Still investigating, looks like websockets aren't being closed properly in a regular case either (seeing lots of Next Day: Next day I will be working on the #11389 task. Continue investigating |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-07): Progress: Something is triggering executor shutdown which then triggers LS shutdown. Hindered debugging due to lack of sufficient logging/missing dev setup on Windows. Tested polyglot version of NodeJS and situation is actually worse - suspend doesn't work on Linux either. Will file a ticket. It should be finished by 2024-11-08. Next Day: Next day I will be working on the #11389 task. Continue investigating |
That obviously meant polyglot version of Ydoc |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-08): Progress: Continue investigating for the source of the bug. Will use PR artifacts to build and test suspend on Windows with additional logging. Filed #11515 for additional problems with Graal-based Ydoc. As a distraction, fixed #11262, no idea how to unit test it though. It should be finished by 2024-11-08. Next Day: Next day I will be working on the #11389 task. Continue investigating |
|
Hubert Plociniczak reports a new STANDUP for yesterday (2024-11-12): Progress: Firefighting CI. While not doing that, analyzing logs for suspend. The issue appears to be rather deep in the stack, hence delays. It should be finished by 2024-11-15. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Fun fact. Even project manager doesn't work after suspend. |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-13): Progress: Continued investigation into abrupt connection close. Meeting about adding support for HTTP cache refresh (11485) It should be finished by 2024-11-15. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-14): Progress: Added support for additional hooks in libs' configs #11485. Continued investigation into abrupt connection close. Fixed one cause of abrupt connection close but something is still preventing reconnection. It should be finished by 2024-11-15. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-15): Progress: Fixed one more connection problem showing up in Akka internal logs. Suspend still continued to fail. Starting to feel like this could be a Ydoc issue. It should be finished by 2024-11-15. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-18): Progress: Current suspend logic, due to Ydoc, completely misses the previous solution (#7801). Checking if adding similar delays within LS could help the situation. Dropped Config work for #11485. It should be finished by 2024-11-22. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for yesterday (2024-11-19): Progress: Planning new tickets, including Akka replacement. Introduced shutdown delays which seems to improve the behaviour on Linux at least. Windows still needs more testing. It should be finished by 2024-11-22. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-20): Progress: Continued debugging issue, shutdowns didn't fix the problem on Windows, connection is still being closed. It should be finished by 2024-11-22. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-21): Progress: Switched to debugging Ydoc server as a source of the problem. Noticed numerous spurious re-connections. It should be finished by 2024-11-22. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-11-22): Progress: Continued debugging ydoc server. Also investigated logging issues in std-bits (filed under #11641). It should be finished by 2024-11-22. Next Day: Next day I will be working on the #11389 task. Continue investigating the issue |
github-project-automation
bot
moved this from 🔧 Implementation
to 🟢 Accepted
in Issues Board
On a laptop waking back up, the application reports the following error:
This was the JSON port of the language server:
[org.enso.languageserver.boot.LanguageServerComponent] Started server at json:127.0.0.1:60829,The text was updated successfully, but these errors were encountered: