Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_database_table to Database Table #6327

Closed
jdunkerley opened this issue Apr 18, 2023 · 3 comments · Fixed by #6467
Closed

Add create_database_table to Database Table #6327

jdunkerley opened this issue Apr 18, 2023 · 3 comments · Fixed by #6467
Assignees
Labels
-libs Libraries: New libraries to be implemented l-db-write Libraries: database writer
Milestone

Comments

@jdunkerley
Copy link
Member

This should allow for direct creation of a DB table based on a constructed DB query.

It should have the same API as #6326.

@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented l-db-write Libraries: database writer labels Apr 18, 2023
@radeusgd
Copy link
Member

Clarifying the spec:

I assume the idea here is to avoid materializing the data and use an INSERT+SELECT query here.

If the target connection is different from the source, it will still fail and require explicit materialization of data (as inter-database transfer is not possible).

@jdunkerley
Copy link
Member Author

Yes this should be on the same backend for this ticket. If a mixed backend we should error and require the user to be explicit.

A SELECT ... INTO <New_Table> should work.

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 18, 2023
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 27, 2023
@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 28, 2023
@enso-bot
Copy link

enso-bot bot commented May 2, 2023

Radosław Waśko reports a new STANDUP for the provided date (2023-04-28):

Progress: Finished the implementation and got the PR ready for review. Well then I realised I forgot to add one test+check (same connection check), so will need to add that. It should be finished by 2023-04-28.

Next Day: Next day I will be working on the #5159 task. Add the missing test/check and get the PR in. Start work on next task - probably will depend on the planning, will look into storage types as that was my original plan for next thing, but will adapt.

@mergify mergify bot closed this as completed in #6467 May 2, 2023
mergify bot pushed a commit that referenced this issue May 2, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-db-write Libraries: database writer
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants