Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_database_table to In-Memory table. #6326

Closed
jdunkerley opened this issue Apr 18, 2023 · 2 comments · Fixed by #6429
Closed

Add create_database_table to In-Memory table. #6326

jdunkerley opened this issue Apr 18, 2023 · 2 comments · Fixed by #6429
Assignees
Labels
-libs Libraries: New libraries to be implemented l-db-write Libraries: database writer

Comments

@jdunkerley
Copy link
Member

Starting to add the new API to write to a Database connection:
Following #5161.

## Creates a new Database table based on either an in-memory table or database query.

   Existing table causes a `Table_Already_Exists` error.
   If the table contains unsupported types (e.g. Enso types) this should error with a message.
   If a lossy conversion will occur then attach a warning.
Table.create_database_table
    connection:Connection
    table_name:Text = Connection.new_table_name
    primary_key:Vector Text = [self.columns.first.name]
    temporary:Boolean = False
    structure_only:Boolean = False
    on_problems:Problem_Behavior = Problem_Behavior.Report_Warning
    -> Database_Table =

The first task should allow creating a DB table from an in-memory table.

  • Table Name should be automatic if temporary but required to be specified if permament.
  • Should be in the schema and database of the connection passed.
@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented l-db-write Libraries: database writer labels Apr 18, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone Apr 18, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 18, 2023
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 24, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 26, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-04-25):

Progress: Added tests and got most of them working. It should be finished by 2023-04-27.

Next Day: Next day I will be working on the same task. Prepare the PR, start work on the next task

@enso-bot
Copy link

enso-bot bot commented Apr 26, 2023

Radosław Waśko reports a new STANDUP for the provided date (2023-04-24):

Progress: Clarified spec, written a documentation for the create_database_table method. Working on implementation. It should be finished by 2023-04-27.

Next Day: Next day I will be working on the same task. Refactor it a bit, add tests, finish implementing.

@radeusgd radeusgd linked a pull request Apr 26, 2023 that will close this issue
5 tasks
@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 26, 2023
@mergify mergify bot closed this as completed in #6429 Apr 27, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-db-write Libraries: database writer
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants