liteeth/gen: Use hw_init_reset for rgmii #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-enables hw_init_reset that was disabled in ea24ff6 ("liteeth_gen: improve readability and add clk_freq checks.") A chip reset is necessary using the Microchip KSZ9031RNX PHY on an antmicro-artix-dc-scm board (possibly depending on startup power timing)
mkj
added a commit
to CodeConstruct/microwatt
that referenced
this pull request
Oct 14, 2022
Non-rgmii devices are unchanged Fixes intermittent ethernet on antmicro-artix-dc-scm. enjoy-digital/liteeth#119 Built with liteeth CodeConstruct/liteeth@dbb13f1 ("liteeth/gen: Use hw_init_reset for rgmii") litex master 4426e618 ("soc/add_pcie: Expose with_synchronizer parameter.") Signed-off-by: Matt Johnston <[email protected]>
|
Hi @mkj, sorry for the delay. The FIXME was probably here when used with the HW stack, I'll have a closer look at the use-case that was requiring it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure of the original reason for this being marked FIXME, so if the
hw_init_resetneeds to remain I can instead make this a configuration option forlitedram_gen.This re-enables hw_init_reset that was disabled in
ea24ff6 ("liteeth_gen: improve readability and add clk_freq checks.")
A chip reset is necessary using the Microchip KSZ9031RNX
PHY on an antmicro-artix-dc-scm board (possibly depending on startup
power timing)