Patch for breaking protoc change. #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Protocol Buffer compiler, protoc, has started appending `final` to generated class definitions as of 3.7. Because of this, our extension classes will no longer build. This removes our dependency on the ability to inherit proto classes, at the cost of using `->` instead of `.` to refer to proto fields from the Data classes.
Noticed the tile loop's counter was unused except to access the tile by that index. Removed.
Codecov Report
@@ Coverage Diff @@
## master #1587 +/- ##
=======================================
Coverage 17.62% 17.62%
=======================================
Files 166 166
Lines 17143 17143
=======================================
Hits 3022 3022
Misses 14121 14121Continue to review full report at Codecov.
|
RobertBColton
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
I checked out the branch and did a clean build of the frontend. I tested a variety of games covering most of the features that could be affected from audio to tiles and graphics. I did not find any regressions running the games through LateralGM or emake. Your workaround is also pretty straight forward and does not require too many additions. These are the reasons I am approving the pull request.
RobertBColton
added a commit
to enigma-dev/RadialGM
that referenced
this pull request
Mar 13, 2019
Pull in Josh's patch from enigma-dev for Protobuf 3.7. enigma-dev/enigma-dev#1587 Also, include the generated proto headers directly as was decided on the enigma-dev repo. enigma-dev/enigma-dev#1591 enigma-dev/enigma-dev#1589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Protocol Buffer compiler, protoc, has started appending
finalto generated class definitions as of 3.7. Because of this, our extension classes will no longer build. This removes our dependency on the ability to inherit proto classes, at the cost of using->instead of.to refer to proto fields from the Data classes.I've filed a bug about the breaking change as protocolbuffers/protobuf#5869, but do not plan to wait for the resolution, since users are having problems now.