go: Add bb-remote-execution dependency #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the golang ecosystem, including: * rules_go to latest release * gazelle to latest release * Go SDK to latest release (1.20.3) This was hopefully going to fix an issue with gazelle and strict dependencies in internal, but doesn't - however, it is still less risky to be on the latest versions if there are no negative effects. One of the unit tests testing byte slices is flaky for unknown reasons (test can't decide if it wants strings in the golden cases or not) so the comparer func is modified to normalize both the "got" and "want" slices to sidestep this issue. Tested: * `bazel test //...` passes * `bazel test //infra/cj/... --override_repository=enkit=<path to enkit>` works in internal
minor-fixes
force-pushed
the
add_buildbarn_dep
branch
2 times, most recently
from
dee1cc5 to
6e69319
Compare
minor-fixes
force-pushed
the
add_buildbarn_dep
branch
from
6e69319 to
40976a1
Compare
mhallmark
approved these changes
Apr 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/buildbarn/bb-remote-executiondefines an RPC service that we'd like to implement. We can:This change attempts to do the former. This came with some complications:
cloud.google.com/go, which causes issues due to the genproto migration that is currently underway. To resolve this, this PR:GoogleCloudPlatform/cloud-build-notifiers, with updated deps and import paths (once go: Update all dependencies to latest GoogleCloudPlatform/cloud-build-notifiers#163 is merged, this fork can be dropped)go_googleapis. Usuallyrules_godoes this for us, but we needed new datastore protos to be compatible with the updated datastore module, and so we must specify the version ourselves and also generate the patches thatrules_gousually does.github.com/bazelbuild/remote-apishas BUILD files that reference@googleapisinstead of@go_googleapis; this is usually patched in the buildbarn ecosystem, but we can't use that patch verbatim due to our updated version of@go_googleapis- so this change adds a slightly modified version of this patch.Tested:
bazel test //... -kworks