go: Update all dependencies to latest #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change attempts to update all third-party dependencies to their latest versions in an attempt to resolve import issues resulting from the collision of the [genproto migration](https://code.googlesource.com/gocloud/+/refs/heads/main/migration.md) and importing Go repositories in a Bazel workspace. This was done by running: ``` go get -u ./... go run cloud.google.com/go/internal/aliasfix/cmd/aliasfix@latest . go mod tidy ``` Tested: * `go build ./...` still works * `go test ./...` still passes
minor-fixes
added a commit
to enfabrica/enkit
that referenced
this pull request
Apr 24, 2023
`github.com/buildbarn/bb-remote-execution` defines an RPC service that we'd like to implement. We can: * depend on this repo as a dependency to use the protos within * copy the protos and their transitive imports into enkit and author our own BUILD files This change attempts to do the former. This came with some complications: * Pulling in this dep upgraded GCP modules under `cloud.google.com/go`, which causes issues due to the [genproto migration](https://code.googlesource.com/gocloud/+/refs/heads/main/migration.md) that is currently underway. To resolve this, this PR: * runs the fixer tool on our code to update import paths, plus gazelle to fix BUILD files * pulls in a fork of `GoogleCloudPlatform/cloud-build-notifiers`, with updated deps and import paths (once GoogleCloudPlatform/cloud-build-notifiers#163 is merged, this fork can be dropped) * pulls in an updated version of `go_googleapis`. Usually `rules_go` does this for us, but we needed new datastore protos to be compatible with the updated datastore module, and so we must specify the version ourselves and also generate the patches that `rules_go` usually does. * `github.com/bazelbuild/remote-apis` has BUILD files that reference `@googleapis` instead of `@go_googleapis`; this is usually patched in the buildbarn ecosystem, but we can't use that patch verbatim due to our updated version of `@go_googleapis` - so this change adds a slightly modified version of this patch. Tested: `bazel test //... -k` works
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to update all third-party dependencies to their latest versions in an attempt to resolve import issues resulting from the collision of the genproto
migration and importing Go repositories in a Bazel workspace.
This was done by running:
Tested:
go build ./...still worksgo test ./...still passes