Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ses)!: Remove support for globalLexicals #1343

Merged
merged 3 commits into from
Oct 28, 2022
Merged

feat(ses)!: Remove support for globalLexicals #1343

merged 3 commits into from
Oct 28, 2022

Commits on Oct 28, 2022

  1. feat(import-bundle)!: Remove support for globalLexicals and inescapab… 

    …leGlobalLexicals

*BREAKING CHANGE*: Removes support for globalLexicals and inescapableGlobalLexicals, and consequently drops support for patterns like metering, where a hidden lexical and censoring transform were able to add invisible machinery to a compartment and all its descendants.
    @kriskowal
    kriskowal committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    c937056 View commit details
    Browse the repository at this point in the history

  2. feat(compartment-mapper)!: Remove support for globalLexicals 

    *BREAKING CHANGE*: Removes support for `globalLexicals`, consistent with changes to SES.
    @kriskowal
    kriskowal committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7d9603d View commit details
    Browse the repository at this point in the history

  3. feat(ses)!: Remove support for globalLexicals 

    Fixes #904

*BREAKING CHANGE*: Removes support for `globalLexicals`.  To our knowledge, there are no production uses for `globalLexicals`.  They currently could leak because `moduleLexicals` and `globalLexicals` used the same scope object, so properties of one would leak to the other with crafted modules.  We had an opportunity to plug the leak at the cost of a fifth scope in all evaluators, but elected to remove the unnecessary complexity instead.
    @kriskowal
    kriskowal committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    3b90d5d View commit details
    Browse the repository at this point in the history