feat(ses)!: Remove support for globalLexicals #1343
Conversation
|
In lieu of #1341 |
|
@warner do we still use the meter transform in agoric-sdk, or is this safe to land? |
kriskowal
force-pushed
the
kris-no-global-lexicals
branch
from
0d2dcfd
to
06598ed
Compare
|
@mhofman It’s perfectly sensible to reverse the commit order. Note that I’ve added another one to propagate the change to |
Nope, we removed that over a year ago (in 5b9563849fa7ca2f26b4ca7c55f10d1d37334f46), at which point we stopped using the |
| inescapableTransforms, | ||
| inescapableGlobalLexicals); | ||
| const endowments = {}; | ||
| const WrappedCompartment = wrapInescapableCompartment( |
There was a problem hiding this comment.
note: the prose at the beginning of this file references the feature being removed, search for provide additional global lexicals to its environment and maybe remove it
There was a problem hiding this comment.
In fact, I think this example needs rethought.. the imposed transform will emit code that still works (it tries to call getOdometer(), which still works, but as a global global, not a global-lexical), but the user code can use globalThis['get'+'Odometer']().read(), which it could not do before
We don't need that restriction in agoric-sdk anymore, and I totally support removing it, but maybe the example we use here should emphasize the transform without also mentioning a confinement behavior that no longer exists.
…leGlobalLexicals *BREAKING CHANGE*: Removes support for globalLexicals and inescapableGlobalLexicals, and consequently drops support for patterns like metering, where a hidden lexical and censoring transform were able to add invisible machinery to a compartment and all its descendants.
*BREAKING CHANGE*: Removes support for `globalLexicals`, consistent with changes to SES.
Fixes #904 *BREAKING CHANGE*: Removes support for `globalLexicals`. To our knowledge, there are no production uses for `globalLexicals`. They currently could leak because `moduleLexicals` and `globalLexicals` used the same scope object, so properties of one would leak to the other with crafted modules. We had an opportunity to plug the leak at the cost of a fifth scope in all evaluators, but elected to remove the unnecessary complexity instead.
kriskowal
force-pushed
the
kris-no-global-lexicals
branch
from
06598ed
to
3b90d5d
Compare
Fixes #904
BREAKING CHANGE: Removes support for
globalLexicals. To our knowledge, there are no production uses forglobalLexicals. They currently could leak becausemoduleLexicalsandglobalLexicalsused the same scope object, so properties of one would leak to the other with crafted modules. We had an opportunity to plug the leak at the cost of a fifth scope in all evaluators, but elected to remove the unnecessary complexity instead.