Publish to GitHub Pages #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preset is just the default settings for the Web target (as of v4.3.stable.flathub [77dcf97d8], at least). The important line is: variant/thread_support=false This selects a build of the Godot web runtime that does not use threads; and hence does not use SharedArrayBuffer; and hence can be used on GitHub Pages where the necessary headers to allow SharedArrayBuffer to be used cannot be set. https://phabricator.endlessm.com/T35699
While it is not necessarily useful to have this game in its default state published to the web, this workflow can be used by a learner who has customised the game in their own repo. The workflow is designed to fail gracefully if GitHub Pages is not available (which is typically the case in a private repo owned by a free account) or not configured correctly. It also only runs on releases or when manually triggered, to avoid running it each time a learner pushes or merges to main. https://phabricator.endlessm.com/T35699
This workflow is intended to be useful to learners who have forked this game as a basis for their own modified game. But rather than using an actual fork, they will likely have downloaded the game from the asset library and committed it to a fresh repository. https://phabricator.endlessm.com/T35699
cassidyjames
approved these changes
Oct 25, 2024
|
Someone in @endlessm/endless-developers with admin access to this repo, please enable GitHub Pages in the repo settings. While you're at it, you can set this repo's URL (on the main/"Code" tab) to Edit: in the wise words of @wjt in endlessm/moddable-platformer#4 (comment):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to endlessm/moddable-platformer#4 except including the two fixups I subsequently pushed to main there.
https://phabricator.endlessm.com/T35699