Publish releases to GitHub Pages #4
Conversation
This preset is just the default settings for the Web target (as of v4.3.stable.flathub [77dcf97d8], at least). The important line is: variant/thread_support=false This selects a build of the Godot web runtime that does not use threads; and hence does not use SharedArrayBuffer; and hence can be used on GitHub Pages where the necessary headers to allow SharedArrayBuffer to be used cannot be set. https://phabricator.endlessm.com/T35699
While it is not necessarily useful to have this game in its default state published to the web, this workflow can be used by a learner who has customised the game in their own repo. The workflow is designed to fail gracefully if GitHub Pages is not available (which is typically the case in a private repo owned by a free account) or not configured correctly. It also only runs on releases or when manually triggered, to avoid running it each time a learner pushes or merges to main. https://phabricator.endlessm.com/T35699
This workflow is intended to be useful to learners who have forked this game as a basis for their own modified game. But rather than using an actual fork, they will likely have downloaded the game from the asset library and committed it to a fresh repository. https://phabricator.endlessm.com/T35699
| publish: | ||
| name: Publish to GitHub Pages | ||
| needs: | ||
| - build-web |
There was a problem hiding this comment.
Does this mean need the build's artifact web?
There was a problem hiding this comment.
It means it needs the build: job, defined above, to have run successfully.
(Logically, yes, that's because it needs to use the web artefact that that job uploads.)
There was a problem hiding this comment.
Argh. I should have paid more attention to your question. There is a typo here: this should read:
| - build-web | |
| - build |
|
Can someone from @endlessm/endless-developers with admin access to the repo set the repo URL to |
|
Maybe the repo URL would be better as the assetlib entry. The web version of the game is not really the interesting part - the point is to get the game into Godot and hack it. We could adjust the readme and mention the web build there. |
|
Yeah fair! |
While it is not necessarily useful to have this game in its default state
published to the web, this workflow can be used by a learner who has customised
the game in their own repo.
The workflow is designed to fail gracefully if GitHub Pages is not available
(which is typically the case in a private repo owned by a free account) or not
configured correctly.
It also only runs on releases or when manually triggered, to avoid running it
each time a learner pushes or merges to main.
The GitHub Actions workflow is intended to be useful to learners who have forked this game as
a basis for their own modified game. But rather than using an actual fork, they
will likely have downloaded the game from the asset library and committed it to
a fresh repository. So we include it in the version published to the asset library.
https://phabricator.endlessm.com/T35699