Download: Add a stage to import all channels #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuq
approved these changes
Jun 9, 2023
dylanmccall
force-pushed
the
issue-548-download-all-collection-channels
branch
from
4e40d5f to
942406c
Compare
|
I made a small change here based on our talk earlier, so the progress bar updates correctly as additional channels are downloaded (and that part of the operation is between 90% and 100%). It could do with another quick look to be sure it's still all right :) |
manuq
approved these changes
Jun 12, 2023
| elif self._stage == DownloadStage.COMPLETED: | ||
| progress = 1 | ||
| progress = PROGRESS_STEPS["completed"] |
Comment on lines
+609
to
+613
| def _get_channel_ids_for_all_content_manifests(): | ||
| channel_ids = set() | ||
| for content_manifest in _content_manifests: | ||
| channel_ids.update(content_manifest.get_channel_ids()) | ||
| return channel_ids |
After the `APPLYING_EXTERNAL_TAGS` stage, the DownloadManager will enter a new `IMPORTING_EXTRA_CHANNELS` stage. In this stage, it should download metadata for any channels which are listed in another content collection. Issue #548
dylanmccall
force-pushed
the
issue-548-download-all-collection-channels
branch
from
16afe2b to
6041906
Compare
|
Thanks for reviewing, @manuq! I'll go ahead and merge this now :) |
|
Available in Ladybird 6.8-338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the
APPLYING_EXTERNAL_TAGSstage, the DownloadManager will enter a newIMPORTING_EXTRA_CHANNELSstage. In this stage, it should download metadata for any channels which are listed in another content collection.Issue #548
The parent issue here wants this stage to happen in the background, and I took a look at that in #579. But I think there's some overlap with #568, so I'm opting for something quick and dirty in this pull request and we can deal with downloading channel metadata in the background separately.