-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download additional channel metadata in the background #592
Comments
Like the unavailable content thumbnails, move the download of the extra channel metadata to the background instead of blocking the initial starter pack download on it. Helps: #592
Like the unavailable content thumbnails, move the download of the extra channel metadata to the background instead of blocking the initial starter pack download on it. Helps: #592
There are some related PRs for this that we should tie up. But this is still not the case - the additional collections are fetched as part of the onboarding flow. It's not too slow though – we don't include massive channels like Khan Academy! – and this way we don't have to deal with inconsistent state. |
I whipped together something in https://github.com/endlessm/kolibri-explore-plugin/tree/background-downloads. It works pretty nicely but needs a little polish and I need to figure out the right way to ensure incomplete tasks are restarted when the app restarts. |
Now that there's a way to serialize background tasks, defer downloading the extra channels so that the initial download completes faster. Since the thumbnail tasks depend on this, they need to be generated on the fly when the channel download completes. Fixes: #592
Now that there's a way to serialize background tasks, defer downloading the extra channels so that the initial download completes faster. Since the thumbnail tasks depend on this, they need to be generated on the fly when the channel download completes. Fixes: #592
Now that there's a way to serialize background tasks, defer downloading the extra channels so that the initial download completes faster. Since the thumbnail tasks depend on this, they need to be generated on the fly when the channel download completes. Fixes: #592
Now that there's a way to serialize background tasks, defer downloading the extra channels so that the initial download completes faster. Since the thumbnail tasks depend on this, they need to be generated on the fly when the channel download completes. Fixes: #592
I'm going to make a new release so this can be tested out in the apps. |
This has been released as kolibri-explore-plugin 6.39.0 with Android Manatee 6.39-393 and Windows 6.39.1.0. @vanessa-chang could you test out the Android app from internal testing? |
I’ve tested the new beta 6.39-393:
I will report another ticket for the back screen issue once it’s clarified. I prefer to have it fixed before we push to the production. Let me know if you have any suggestions. Thank you |
Please do. I have a feeling this is because the background downloads never actually stop when the app is closed. learningequality/kolibri#11120 will help that a lot but hasn't been released yet. |
@dbnicholson thanks. I have open the ticket #769 for the issue. I currently report in the Kolibri-explore-plugin repo. However, as this issue cannot be reproduced in the Windows app, let me know if I should file in the other repo for a correction. Thanks. |
In #548 / #580, we added a system where kolibri-explore-plugin downloads metadata for channels from all content collections, instead of just channels from the initial content collection. At the moment, this is an extra stage in that initial content import which blocks the UI until it is finished. Instead, we would like for this additional metadata download to happen in the background while the user is browsing content.
The text was updated successfully, but these errors were encountered: