-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download thumbnails for content that is not available locally #549
Comments
I wrote:
@manuq wrote:
|
I ran the following script on the prod key instance:
And I ran that by having it be read on stdin like Here's what it came up with:
Note that I did not filter on |
I started looking at how we would ingest all the thumbnails for a channel rather than just the thumbnails for the desired content nodes. It looks like it will need some work. Kolibri's importing works at the content node level, but thumbnails are a level below content nodes. Kolibri has no "import just the thumbnail for a content node but not the actual content" knob. I think there are 3 options:
|
I asked on Slack if the |
I opened learningequality/kolibri#10770 upstream. learningequality/kolibri@develop...dbnicholson:kolibri:all-thumbnails has my WIP branch, but I'm still working through some test failures. |
PR ready upstream learningequality/kolibri#10780. |
The app has been updated to Kolibri v0.16.0-alpha15. Ready to make use of the all_thumbnails feature. |
I suggest to go back to the initial PR that was just adding the "all_thumbnails" option so we can merge it now. Doing it in the background requires a bit more work in the frontent, not just the backend. |
Cleanup merged. |
In order to provide a rich display of unavailable content, thumbnails for the missing content are desired. After the initial starter pack download has completed, queue up tasks to download all missing content thumbnails in the background. This uses a new `all_thumbnails` option for the `remotecontentimport` Kolibri task added after 0.16.0-alpha14. The option is ignored on older releases. This introduces a new `FOREGROUND_COMPLETED` stage in for the download manager. It has no tasks in it, but it separates the foreground tasks from the background tasks. Once `FOREGROUND_COMPLETED` has been reached, progress is reported to the frontend as complete and the remaining tasks will be enqueued in the background without any interaction from the frontend. Fixes: #549
Sorry, I missed this message. I can still do that and punt on backgrounding, but I think the current iteration of #584 works nicely minus the frontend integration. |
In order to provide a rich display of unavailable content, thumbnails for the missing content are desired. After the initial starter pack download has completed, queue up tasks to download all missing content thumbnails in the background. This uses a new `all_thumbnails` option for the `remotecontentimport` Kolibri task added after 0.16.0-alpha14. The option is ignored on older releases. This introduces a new `FOREGROUND_COMPLETED` stage in for the download manager. It has no tasks in it, but it separates the foreground tasks from the background tasks. Once `FOREGROUND_COMPLETED` has been reached, progress is reported to the frontend as complete and the remaining tasks will be enqueued in the background without any interaction from the frontend. Fixes: #549
Deployed: kolibri-explore-plugin v6.17.0 |
Depending on how fast you press the "show me" button after the content has been downloaded during the onboarding the thumbnails might be there or not. The download of the thumbnails might still be ongoing. There is no way to tell the user "new thumbnails, wanna refresh?" yet - this is covered https://github.com/orgs/endlessm/projects/3/views/8?pane=issue&itemId=31379558 |
In Kolibri's terms, these are not part of the channel's metadata but are content items in their own right.
When we download metadata for additional collections besides the one the user picks (#548) we'll then want to download thumbnails for the content in those collections, so that users can explore it (#545) visually.
The text was updated successfully, but these errors were encountered: