-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to navigate unavailable channels and content #545
Comments
This is ready for review. It's under a feature flag so it should be safe to merge. To test it:
|
I tested this using a KOLIBRI_HOME where I previously imported the artist starter pack (to test the featured channels). Initially only the channels I had before were appearing in the Library tab, but after I stopped Kolibri, ran
Trying to access the resource from a node currently displays an error, which I also believe is expected at this point: Then I deleted and recreated my KOLIBRI_HOME, importing the artist starter pack again, and was expecting to see more channels in the library, per @manuq's comment "Current starter packs would work too as they are now importing way more metadata than needed", but it showed me the same channels as before, so IDK how to test that part. Perhaps the artist starter pack does not have more metadata then needed? Even with the comments above, I'm considering this a CR+ and will go ahead with merging it. |
Released internally:
Here is how to test this with the feature flag on Android: https://phabricator.endlessm.com/w/apps/endlesskey/chromebook/#edit-the-kolibri-options |
Tested this yesterday in the Playthrough as working. |
Add a new plugin boolean option
NAVIGATE_UNAVAILABLE
that defaults to false. If true:The text was updated successfully, but these errors were encountered: