Fix bug when a macro returns a field #37

rw-access · 2020-07-27T15:32:03Z

Issues

Closes #36

Fixed a bug that was introduced with #16. When a macro expanded to a field, there was an uncaught exception at

Lines 721 to 722 in c76c36a

    
           if ast_node.base not in self._var_types: 
        
               ast_node, type_hint = self._update_field_info(node, ast_node)

. The line just needed to be updated to account for NodeInfo and the current type tracking.

brokensound77

LGTM

rw-access added 2 commits July 27, 2020 09:22

Fix bug when using macros with a schema

20ebf69

Remove schema from tests

56a83b9

rw-access added the enhancement New feature or request label Jul 27, 2020

rw-access requested a review from brokensound77 July 27, 2020 15:32

rw-access added 4 commits July 27, 2020 09:33

Update CHANGELOG.md

48757e9

Remove unnecessary imports

ec9c5c5

Switch to EqlTypeMismatchError

b68210a

Restore Schema for unit test

82f6c0d

rw-access changed the title ~~Fix bug when using macros with a schema~~ Fix bug when a macro returns a field Jul 27, 2020

rw-access added bug Something isn't working and removed enhancement New feature or request labels Jul 27, 2020

brokensound77 approved these changes Jul 27, 2020

View reviewed changes

rw-access merged commit 23a5253 into endgameinc:master Jul 27, 2020

rw-access deleted the bug/macro-expansion-hints branch July 27, 2020 16:10

	if ast_node.base not in self._var_types:
	ast_node, type_hint = self._update_field_info(node, ast_node)